Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust docs for Sphinx v6 #112

Closed
khaeru opened this issue Jan 9, 2023 · 2 comments · Fixed by #121
Closed

Adjust docs for Sphinx v6 #112

khaeru opened this issue Jan 9, 2023 · 2 comments · Fixed by #121
Assignees
Labels
doc Documentation, help, examples, etc.

Comments

@khaeru
Copy link
Owner

khaeru commented Jan 9, 2023

Sphinx 6.0.0 was released on 2022-12-29; since then, the CI step "Test documentation build using Sphinx" has failed, e.g. here, with:

writing output... [  5%] api

Exception occurred:
  File "/opt/hostedtoolcache/Python/3.11.1/x64/lib/python3.11/site-packages/pydata_sphinx_theme/bootstrap_html_translator.py", line 27, in visit_table
    self.generate_targets_for_table(node)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'BootstrapHTML5Translator' object has no attribute 'generate_targets_for_table'

Investigate and adjust.

@khaeru khaeru added the doc Documentation, help, examples, etc. label Jan 9, 2023
@khaeru khaeru self-assigned this Jan 9, 2023
@khaeru
Copy link
Owner Author

khaeru commented Jan 10, 2023

On closer inspection this appears to be pydata/pydata-sphinx-theme#1098. Until this is closed, the mitigation may be to require sphinx < 6.0.0.

@khaeru
Copy link
Owner Author

khaeru commented Jan 16, 2023

pydata-sphinx-theme is required via sphinx-book-theme. The latter package has been adjusted to exclude Sphinx 6 (executablebooks/sphinx-book-theme#644) but this has not yet been released. Until that happens, sdmx1 will need to mirror that exclusion → #113

khaeru added a commit that referenced this issue Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation, help, examples, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant