-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A null offset is a valid value #172
Comments
This reverts commit 02616ab. Make OTS happy. Phew. khaledhosny/ots#172
Do you have a test font (or how can I make one)? |
@nyshadhr9 can you please provide this? |
This (or something similar) also happens on attempting to sanitise Noto Sans VF's mark-to-ligature lookups. |
I'm not sure this is true.... where does the spec say this? It's not mentioned at https://learn.microsoft.com/en-gb/typography/opentype/spec/gdef#mark-glyph-sets-table, AFAICS. (Note that MicrosoftDocs/typography-issues#828 (comment) and following comments seem to state the opposite, unless the specific field is explicitly documented as allowing null.) |
Fair. Let's look at it from this angle: All major implementations allow this. |
That may well be so -- I haven't attempted to check. But Peter's comment at MicrosoftDocs/typography-issues#828 (comment) said:
though I don't know what specific implementations he was referring to. cc @PeterCon |
In the fonttools subsetter I made it output null offset if a Coverage table is empty in MarkGlyphSets in GDEF. But ots fails on that.
Null offsets are perfectly fine according to the spec, and all implementations accept them. Yet another OTS stupidity :(.
The text was updated successfully, but these errors were encountered: