Warn rather than fail if min/max of a condition table range are reversed #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfkthame
force-pushed
the
filter-range-warning
branch
from
cd16f60 to
e20e492
Compare
khaledhosny
reviewed
Oct 1, 2024
…rning. Condition table format 1 is described at https://learn.microsoft.com/en-gb/typography/opentype/spec/chapter2#condition-table-format-1-font-variation-axis-range In mozilla bug https://bugzilla.mozilla.org/show_bug.cgi?id=1916037, we saw fonts being rejected due to incorrectly-ordered min/max values in this table, but this does not need to be a hard error; we can just issue a warning.
jfkthame
force-pushed
the
filter-range-warning
branch
from
e20e492 to
2f38c58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An improperly ordered filter range is a non-fatal error; just issue a warning.
Condition table format 1 is described at
https://learn.microsoft.com/en-gb/typography/opentype/spec/chapter2#condition-table-format-1-font-variation-axis-range
In mozilla bug https://bugzilla.mozilla.org/show_bug.cgi?id=1916037, we saw fonts being rejected due to incorrectly-ordered min/max values in this table, but this does not need to be a hard error.