Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/inventory api client #83

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

alkhimch
Copy link

Issue codes

Features

  • Implement feign client
  • configure env files with example
  • example feign API added

PS: I've changed .env.example to application-local-example.properties. Maybe it can be wrong, I'll remove it. Also I tested feign client that starting 2 projects.

BR, alkhimch

Copy link

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines Coverage Δ Complexity Δ
.../main/java/com/fjb/product/ProductApplication.java 33.33% <ø> (ø) 1.00 <0.00> (ø)

... and 7 files with indirect coverage changes

@alkhimch
Copy link
Author

@khanhduzz pls review this PR

@khanhduzz
Copy link
Owner

Hi @alkhimch, it seems you have something to fix with snyk, I'm so busy these days, so I will try to take time and review your PR later, thank for your patient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants