Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Category] Fix/category #130

Merged
merged 21 commits into from
Sep 25, 2024
Merged

[Category] Fix/category #130

merged 21 commits into from
Sep 25, 2024

Conversation

Longlay12
Copy link
Collaborator

add unit test categoryServiceImpl

Copy link

Copy link

Sunrise Coverage Report

Overall Project 23.88% -0.56%
Files changed 45.16% 🍏

File Coverage
CategoryServiceImpl.java 56.01% -4.09% 🍏

Copy link
Owner

@khanhduzz khanhduzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...fjb/sunrise/services/impl/CategoryServiceImpl.java 42.85% 3 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines Coverage Δ Complexity Δ
...fjb/sunrise/services/impl/CategoryServiceImpl.java 52.43% <42.85%> (+29.36%) 13.00 <0.00> (+5.00)

... and 1 file with indirect coverage changes

@khanhduzz khanhduzz merged commit cfa1577 into main Sep 25, 2024
8 checks passed
@khanhduzz khanhduzz deleted the fix/category branch September 25, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants