adds coords on surfaces, & pre-smoothing for curv #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfolded coords now generated as a surface metric too, is especially needed if using surfaces other than 32k. Also added smoothing to mid-surface prior to curvature calculation. unrelated: Fixed config yml issue that always added rule 'all', even if target rule specified from command-line
|
Seems to be working fine, so merging this in |
akhanf
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfolded coords now generated as a surface metric too, is especially needed if using surfaces other than 32k.
Also added smoothing to mid-surface prior to curvature calculation (thanks @Bradley-Karat for testing out parameters for this step)
Unrelated: Fixed config yml issue that always added rule 'all', even if target rule specified from command-line