Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qc fixes #120

Merged
merged 3 commits into from
Dec 4, 2021
Merged

qc fixes #120

merged 3 commits into from
Dec 4, 2021

Conversation

akhanf
Copy link
Member

@akhanf akhanf commented Dec 1, 2021

Some updates for qc rules:

  • closes qc_reg_to_template failing  #113 (at least I can't reproduce that error anymore..)
  • adds back the surf qc pngs (needed density wildcards)
  • puts dseg qc into a single subplotted png, instead of 3 separate ones
  • uses dim=-0.5 for plotting instead of -1 (I was getting very dark images occasionally, this makes it more stable)

- added den-{density} wildcard for surf pngs
- dim=-0.5 instead of -1
@akhanf akhanf added the bug Something isn't working label Dec 1, 2021
@akhanf akhanf requested a review from jordandekraker December 1, 2021 00:57
Copy link
Collaborator

@jordandekraker jordandekraker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, and it worked in my test case!

We may want to add a .html file combining all of these at some point, but that's maybe a future addition

@akhanf akhanf merged commit 35d0ca8 into master Dec 4, 2021
@akhanf akhanf deleted the qcfix branch December 4, 2021 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qc_reg_to_template failing
2 participants