Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single modality at a time #137

Merged
merged 17 commits into from
Dec 26, 2021
Merged

single modality at a time #137

merged 17 commits into from
Dec 26, 2021

Conversation

akhanf
Copy link
Member

@akhanf akhanf commented Dec 18, 2021

  • change modality from a list to a string
  • removes modality wildcard from all (except work tar file)
  • changes seg_{modality} and surf_{modality} to seg_ and surf_ (allowing
    for further refactoring)
  • T2w workflow updated and dry-run tested, others are WIP

- change modality from a list to a string
- removes modality wildcard from all (except work tar file)
- changes seg_{modality} and surf_{modality} to seg_ and surf_ (allowing
for further refactoring)
- T2w workflow updated and dry-run tested, others are WIP
@akhanf akhanf marked this pull request as ready for review December 18, 2021 21:42
@akhanf
Copy link
Member Author

akhanf commented Dec 18, 2021

ok this looks good to review and merge in -- I didn't do any other refactoring here (except for renaming seg_{modality} and surf_{modality} to seg and surf.

@jordandekraker
Copy link
Collaborator

This might be a good place for one more thing - perhaps we should change the default modality to T1w? This seems to be most common plus in many cases it seems to work better

@akhanf
Copy link
Member Author

akhanf commented Dec 21, 2021

Yeah I agree, I think defaulting to T2w doesn't make sense anymore..

I am thinking we should just make --modality a required argument and not have any default at all. That avoids any surprises in changing the default, and is probably safer since we are no longer allowing multiple different modalities in the same folder..

@akhanf akhanf added the enhancement New feature or request label Dec 22, 2021
@jordandekraker
Copy link
Collaborator

Ah didn't realize you updates the name. warps.smk will need 'seg_{modality}' replaces with just 'seg'

@akhanf
Copy link
Member Author

akhanf commented Dec 26, 2021

ya I updated those already with a recent merge of master.. I'll fix the remaining conflicts now (after merging in neonatal) then merge this in

@akhanf akhanf merged commit e46d23b into master Dec 26, 2021
@akhanf akhanf deleted the 1modality branch December 26, 2021 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants