-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
root dir change for snakebids 0.4.0 #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- uses root or work variables instead of 'results' and 'work' to enable bids-app and workflow modes (snakebids 0.4.0)
This PR now also changes the way we dry-run test the workflow, putting the tests in the github workflow instead of a separate python file and pytest. Did this because of some incompatibilities with the way we were testing and snakebids, but it should make adding new dry-run tests much easier.. |
akhanf
added
maintenance
Updates or improvements that do not change functionality of the code
enhancement
New feature or request
breaking
New feature that breaks comptability with previous versions
labels
Jan 5, 2022
jordandekraker
approved these changes
Jan 6, 2022
akhanf
removed
enhancement
New feature or request
breaking
New feature that breaks comptability with previous versions
labels
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to refactoring proposed in #123.
It changes output folder structure to prepend
results/
folder when in workflow mode (run with snakemake), and not prependresults/
folder when in bids-app mode (run with hippunfold CLI)In addition to this change, outputs are now placed in
hippunfold
andwork
folders, which are siblings (analogous toresults
andwork
from before).These changes mean that when run in workflow mode, all the outputs are in
results/hippunfold
andresults/work
(ie according to snakemake best practices to not crowd the snakemake root folder), and when run in bids-app mode, all outputs are inhippunfold
andwork
.Note: more substantial refactoring could be done in later PR(s), where we can:
coords
andxfm
temp()
directive throughout the workflow instead of using a separate work path. This would mean we could drop thecopy_to_results
rule, and instead of--keep_work
can use the snakemake--notemp
option to keep the temporary files