Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-formatting and quality-checks #148

Merged
merged 4 commits into from
Jan 6, 2022
Merged

Auto-formatting and quality-checks #148

merged 4 commits into from
Jan 6, 2022

Conversation

akhanf
Copy link
Member

@akhanf akhanf commented Jan 6, 2022

this runs automatic code formatting (isort, black, snakefmt) to make the code consistent and easier to read.

akhanf added 2 commits January 6, 2022 15:29
- ran poe quality_fix on the code to automatically format everything
- quality_check now passes successfully
@akhanf akhanf added the maintenance Updates or improvements that do not change functionality of the code label Jan 6, 2022
@akhanf akhanf marked this pull request as ready for review January 6, 2022 20:59
@akhanf akhanf requested a review from jordandekraker January 6, 2022 21:00
@akhanf
Copy link
Member Author

akhanf commented Jan 6, 2022

@jordandekraker thought it would be a good time to run the automated formatting since we don't have (any?) other PRs on the go.. if you do have other active branches, the best thing to would be to run: snakefmt hippunfold to automatically format everything before trying to merge, otherwise you will have all sorts of conflicts..

@akhanf
Copy link
Member Author

akhanf commented Jan 6, 2022

Once this is merged in, for future PRs you should be able to use poe quality_fix to make sure the code passes the quality checks. I'll also try to set-up some pre-commit hooks to automatically do this at some point in the future..

@jordandekraker
Copy link
Collaborator

Looks great! I have no other branches so yes definitely a good time to get this done.

I see you have some other open branches including active poetry and snakebids-0.4.0 - are those still needed? might also be a good time to trim them

@akhanf akhanf merged commit 031d779 into master Jan 6, 2022
@akhanf akhanf deleted the snakefmt branch January 6, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Updates or improvements that do not change functionality of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants