-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allowing qc to use corobl #159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - though the name of the wildcard isn't actually important (ie technically it just has to be consistent between inputs and outputs of a rule) but good to have some consistency across rules or for semantic purposes..
was still throwing some errors with different modalities, but i think i have it fixed now. I think the current Check error is maybe a linting thing? I'll check it out |
taking a look at this now -- after fixing the formatting errors the hippb500 workflow was broken, so will adjust accordingly.. |
Noticed that the qc folder was nearly empty when the output space is corobl (eg with
--modality cropseg
). This should fix that (slice views will have no background image)