Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowing qc to use corobl #159

Merged
merged 11 commits into from
Jan 15, 2022
Merged

allowing qc to use corobl #159

merged 11 commits into from
Jan 15, 2022

Conversation

jordandekraker
Copy link
Collaborator

Noticed that the qc folder was nearly empty when the output space is corobl (eg with --modality cropseg). This should fix that (slice views will have no background image)

@jordandekraker jordandekraker added the bug Something isn't working label Jan 14, 2022
Copy link
Member

@akhanf akhanf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - though the name of the wildcard isn't actually important (ie technically it just has to be consistent between inputs and outputs of a rule) but good to have some consistency across rules or for semantic purposes..

@jordandekraker
Copy link
Collaborator Author

was still throwing some errors with different modalities, but i think i have it fixed now. I think the current Check error is maybe a linting thing? I'll check it out

@akhanf
Copy link
Member

akhanf commented Jan 15, 2022

taking a look at this now -- after fixing the formatting errors the hippb500 workflow was broken, so will adjust accordingly..

@akhanf akhanf merged commit baa0268 into master Jan 15, 2022
@akhanf akhanf deleted the corobl_qc branch January 15, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants