Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added logging #160

Merged
merged 4 commits into from
Jan 16, 2022
Merged

added logging #160

merged 4 commits into from
Jan 16, 2022

Conversation

akhanf
Copy link
Member

@akhanf akhanf commented Jan 15, 2022

  • this is a cosmetic fix (doesn't change outputs, except for log files)
  • the logs printing were screen were an eyesore for some time, so went through and tried to add logs to any rules that were doing this

@akhanf
added logging
bf4401f 
- logs written to file for (hopefully) all rules that were writing stdout
- had to change nighres script to shell to achieve this
@akhanf akhanf added the maintenance Updates or improvements that do not change functionality of the code label Jan 15, 2022
@akhanf akhanf requested a review from jordandekraker January 16, 2022 17:38
jordandekraker
jordandekraker approved these changes Jan 16, 2022
View reviewed changes
Copy link
Collaborator

@jordandekraker jordandekraker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh this should make things a lot neater! I didn't test yet but it all looks good to me

@akhanf
Copy link
Member Author

akhanf commented Jan 16, 2022

I ran a test on real data to confirm earlier so should be good

@akhanf akhanf merged commit 1900460 into master Jan 16, 2022
@akhanf akhanf deleted the logfiles branch January 16, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordandekraker jordandekraker jordandekraker approved these changes

Assignees
No one assigned
Labels
maintenance Updates or improvements that do not change functionality of the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akhanf @jordandekraker