Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose crop_native_box as a config and CLI variable #184

Merged
merged 3 commits into from
May 31, 2022
Merged

expose crop_native_box as a config and CLI variable #184

merged 3 commits into from
May 31, 2022

Conversation

akhanf
Copy link
Member

@akhanf akhanf commented May 27, 2022

was hard-coded to 256x256x256vox

@akhanf akhanf marked this pull request as ready for review May 27, 2022 18:09
@akhanf akhanf requested a review from Bradley-Karat May 27, 2022 18:09
@akhanf
Copy link
Member Author

akhanf commented May 27, 2022

@Bradley-Karat can you try this with your data? If you want a container build we can use a github action to build this branch..

@Bradley-Karat
Copy link
Collaborator

Test case worked and the spacing issue is now fixed in the YAML

@akhanf akhanf added the enhancement New feature or request label May 31, 2022
@akhanf
Copy link
Member Author

akhanf commented May 31, 2022

awesome thanks, will merge this in now..

@akhanf akhanf changed the title expose crop_native_box as a config variable expose crop_native_box as a config and CLI variable May 31, 2022
@akhanf akhanf merged commit 1449a07 into master May 31, 2022
@akhanf akhanf deleted the crop_native_box branch May 31, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bradley-Karat Bradley-Karat Awaiting requested review from Bradley-Karat

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akhanf @Bradley-Karat