bugfix: subfield+tissue for new atlases, and tsv files #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two related fixes: 1. New atlases were still using the bigbrain dseg.tsv for generating the subfield volumes.tsv files. These have now been added. 2. The way the postproc tissue labels (dg, srlm, cyst) were being added to the subfields was also hardcoded for the bigbrain atlas. Have now added a section in the config file to customize what labels these map to, so that e.g. the dentate gyrus is merged into the existing label number, and that the SRLM/Cyst labels do not conflict with the labels, and are maximal (so they override the others). Previously the magdeburg subiculum label (8) was same as cyst, so these became merged.
|
tested and working, so merging this in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two related fixes:
New atlases were still using the bigbrain dseg.tsv for generating the
subfield volumes.tsv files. These have now been added.
The way the postproc tissue labels (dg, srlm, cyst) were being added
to the subfields was also hardcoded for the bigbrain atlas. Have now
added a section in the config file to customize what labels these map
to, so that e.g. the dentate gyrus is merged into the existing label
number, and that the SRLM/Cyst labels do not conflict with the labels,
and are maximal (so they override the others). Previously the magdeburg
subiculum label (8) was same as cyst, so these became merged.