Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defined in mm instead of vox #224

Merged
merged 3 commits into from
Nov 27, 2022
Merged

defined in mm instead of vox #224

merged 3 commits into from
Nov 27, 2022

Conversation

jordandekraker
Copy link
Collaborator

this should be more robust to different input image resolutions. 52mm iso should be enough to cover the whole hippocampus.

this should be more robust to different input image resolutions. 52mm iso should be enough to cover the whole hippocampus.
@jordandekraker jordandekraker added the enhancement New feature or request label Nov 17, 2022
@akhanf
Copy link
Member

akhanf commented Nov 17, 2022

Isn't this a much smaller bounding box? (256 x 0.3mm = 76.8mm)

@jordandekraker
Copy link
Collaborator Author

I believe voxel size was relative to the input image, so in my case I had a 0.8mm being increased 400% to 0.2mm isotropic in the cropT1w, which worked out to 51.2mm. Just testing now so I'll confirm whether this is a good new default or not

@akhanf
Copy link
Member

akhanf commented Nov 17, 2022

Ah yes forgot about that, yes you're right!

@jordandekraker
Copy link
Collaborator Author

while we're at it, i wonder if its worth setting a fixed voxel size, or maybe just making it relative to the space-corobl?

@akhanf
Copy link
Member

akhanf commented Nov 17, 2022

I'm good with changing it to be a fixed size (rather than 400% relative), specified in a config file and/or cmd line arg?

@jordandekraker
Copy link
Collaborator Author

Great, I'll set that up right now! I'll keep the default to 0.2mm (or 0.3mm?) to minimize loss when rotating the corobl back to native (which is usually about 25-30deg sagittal rotation)

@akhanf
Copy link
Member

akhanf commented Nov 17, 2022

yep I'm good with either one

@akhanf akhanf merged commit b4f3862 into master Nov 27, 2022
@akhanf akhanf deleted the default-cropT1w-res branch November 27, 2022 21:28
@akhanf akhanf mentioned this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants