T1T2w model file/url was missing from the config #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem was I neglected to add the T1T2w model file/url info, even though the model is available on zenodo along with the others. The error was occurring in get_model_tar(), but was causing the following cryptic error: ``` CyclicGraphException in line 225 of /home/zeng/Documents/hippunfold/hippunfold/workflow/rules/gifti.smk: Cyclic dependency on rule warp_gii_to_native. ``` since the get_model_tar() function was silently failing since the T1T2w model key didn't exist in the config. An additional check has now also been added which should give a more meaningful error message if this were to happen in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #229.
Problem was I neglected to add the T1T2w model file/url info, even though the model is available on zenodo along with the others.
The error was occurring in get_model_tar(), but was causing the following cryptic error:
since the get_model_tar() function was silently failing since the T1T2w model key didn't exist in the config.
An additional check has now also been added which should give a more meaningful error message if this were to happen in the future.
Note: to use the T1T2w model you will have to run
hippunfold_download_modelsagain (will download missing models only). I'll also build a new container so it is present there too..