Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added neonate_v2 model, minor workflow update for it #249

Merged
merged 2 commits into from
Aug 2, 2023
Merged

added neonate_v2 model, minor workflow update for it #249

merged 2 commits into from
Aug 2, 2023

Conversation

akhanf
Copy link
Member

@akhanf akhanf commented Aug 2, 2023

  • trained on manually-corrected synthseg segmentations
  • inadvertendly picked a non-default "trainer" for nnUNet, so had to also made a minor update to the workflow to support choice of trainer (which was easy since trainer was in the tar name).
  • note: this was a mixup when migrating back and forth from nnunet-v2, and I ultimately didn't end up using nnunet-v2 because it would have made it difficult to support both nnunet and nnunet-v2 models (not backwards compatible).

akhanf added 2 commits August 2, 2023 14:43
@akhanf
added neonate_v2 model, minor workflow update for it
edee5a4 
- trained on manually-corrected synthseg segmentations
- inadvertendly picked a non-default "trainer" for nnUNet, so had to
  also made a minor update to the workflow to support choice of trainer
   (which was easy since trainer was in the tar name).
- note: this was a mixup when migrating back and forth from nnunet-v2, and I ultimately didn't
  end up using nnunet-v2 because it would have made it difficult to support both
  nnunet and nnunet-v2 models (not backwards compatible).
@akhanf
linting
bd63897
@akhanf akhanf marked this pull request as ready for review August 2, 2023 23:56
@akhanf akhanf merged commit 5194adb into master Aug 2, 2023
@akhanf akhanf deleted the neonate-v2 branch August 2, 2023 23:56
@akhanf akhanf added enhancement New feature or request maintenance Updates or improvements that do not change functionality of the code and removed enhancement New feature or request labels Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance Updates or improvements that do not change functionality of the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@akhanf