-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fast laplace via initialization #88
Conversation
the backwards fastmarch solution is weighted less heavily near 1 (its maximum) (by squaring) and then it is flipped (-backward +1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if its a great idea to make this combined initialization the new default..
The combination is not really principled by just averaging them together.. I think it would be more sensible to have an option to select the initialization type.
Could also just keep the forward or the backward. The only problem is the end point from one direction doesn't match the start point from the other, so I wanted the combination to be weighted more heavily towards the start of each march. If that's too complicated then just one of the two marches would still be a good initialization |
Now that I think about it, if i want to weight their combination, then maybe I should flip them both, square them, flip one back, average them, and then square root the whole thing. Whatever the combination method is (just using one direction, averaging them, or doing a weighted average) is still a huge improvement over just initializing with a value of 0.5, and so choosing a combination method is a pretty minor change in comparison. |
Sorry I may have misunderstood the change when I glanced over it, I thought
you were averaging the injected coords with fast marching coords?
…On Mon., Jul. 12, 2021, 11:24 a.m. jordandekraker, ***@***.***> wrote:
Now that I think about it, if i want to weight their combination, then
maybe I should flip them both, square them, flip one back, average them,
and then square root the whole thing.
Whatever the combination method is (just using one direction, averaging
them, or doing a weighted average) is still a huge improvement over just
initializing with a value of 0.5, and so choosing a combination method is a
pretty minor change in comparison.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#88 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACXV2XPAEUXYSPH5YGIXNKLTXMCLXANCNFSM5AEMHRFA>
.
|
Nope, this is only for when there is not shape injection (and therefore no initialization injection). |
Did some quick testing and just averaging the forward and backward march seems to consistently do best (weighting averaging was getting very complicated). Can probably merge anytime |
I recycled some old matlab code to get a fast (and good quality) initialization for the lapalce solver. Only dependency is scikit-fmm which is pretty light.
This could be used in conjunction with image pyramids as in #85, but honestly I think this is fast enough now.
Tested and working on my end!