Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script create_warps.py resource management #94

Closed
wants to merge 6 commits into from

Conversation

jordandekraker
Copy link
Collaborator

No description provided.

Jordan DeKraker - B. Bernhardt Lab added 3 commits July 26, 2021 09:51
@jordandekraker
Copy link
Collaborator Author

Proceeding as discussed in #92

@jordandekraker
Copy link
Collaborator Author

jordandekraker commented Aug 10, 2021

Currently, the max matrix size is set to 200*200*200 = 8M. In space-corobl, matrix size is 128*256*128 = 4.2M.

Could perhaps set the max matrix size even larger, though in my other test cases this hangs (despite never reaching even close to memory limit).

Another quick note: its not actually the matrix size that matters but the number of GM voxels (which in my ex-vivo case was 456K after downsampling. In space-corobl this is typically ~80K). This could vary quite a bit depending on the sample, so matrix size is probably a better basis for downsampling.

@jordandekraker
Copy link
Collaborator Author

After spending a long time trying to get this step (and the next) to work on 3D PLI and BigBrain data at super high resolution, I realized the issue wasn't memory. I'll leave https://github.com/khanlab/hippunfold/tree/create_warps_resource_manage as is in case we need further memory management (in this case by downsampling) in the future.

The actual issue is outlined here:
https://stackoverflow.com/questions/10886971/alternatives-to-scipy-interpolate-griddata-that-dont-hang-on-aligned-points

I created a new branch with this fix: #95

@jordandekraker
Copy link
Collaborator Author

Closing this PR as it is no longer needed, but may be useful if we need downsampling to manage memory in the future!

@jordandekraker jordandekraker deleted the create_warps_resource_manage branch January 6, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant