Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand over sessions, update config call #70

Merged
merged 8 commits into from
Apr 26, 2023

Conversation

kaitj
Copy link
Collaborator

@kaitj kaitj commented Apr 26, 2023

Proposed changes

Resolves #63 and took advantage to update the dependencies.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • Code has been run through the poe quality task
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

@kaitj kaitj added the maintenance Updates or improvements that do not change functionality of the code label Apr 26, 2023
Copy link
Collaborator

@tkkuehn tkkuehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me with a couple of caveats:

  • Would be good to add a test case including a session (i.e. new test dataset under test, add a task to pyproject.toml, and add it to the test workflow)
  • Not new to this PR, but we'll probably need to change inputs.subj_wildcards to a specific component .wildcards to handle the additional wildcards we don't care about in Add additional wildcard entities #69.

You can go ahead and merge once you add the test (assuming you agree it's worth adding)

kaitj added 5 commits April 26, 2023 12:17
- update config calls to reflect snakebids updates (e.g.
  inputs['T1w'].<entity> vs config["T1w"][<entity>])
@kaitj kaitj force-pushed the sessions_config_update branch from 7ab41b7 to cead754 Compare April 26, 2023 16:33
@kaitj kaitj force-pushed the sessions_config_update branch from cead754 to f76d252 Compare April 26, 2023 16:35
@kaitj
Copy link
Collaborator Author

kaitj commented Apr 26, 2023

Fixed a couple of bugs with the sessions. @tkkuehn mind taking another look before I merge this in?

Will also look to move towards snakebids >= 0.8 in a separate PR. We can potentially think about creating a release from this and move the next version of snakebids and registration optimization, etc. in the next release.

@kaitj kaitj force-pushed the sessions_config_update branch from 5a1a1d0 to c295a1f Compare April 26, 2023 16:58
@kaitj kaitj merged commit 7fd3d5c into khanlab:main Apr 26, 2023
@kaitj kaitj deleted the sessions_config_update branch April 26, 2023 17:52
@kaitj kaitj restored the sessions_config_update branch April 26, 2023 17:52
@kaitj kaitj deleted the sessions_config_update branch April 26, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Updates or improvements that do not change functionality of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle datasets with sessions
2 participants