Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch fix for docker deploy #88

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Patch fix for docker deploy #88

merged 1 commit into from
Sep 25, 2023

Conversation

kaitj
Copy link
Collaborator

@kaitj kaitj commented Sep 25, 2023

Proposed changes

A patch fix to the deploy workflow such that dockerhub credentials are passed. Will create a v0.3.1 release after merging.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • Code has been run through the poe quality task
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

@kaitj kaitj added the bug Something isn't working label Sep 25, 2023
@kaitj kaitj merged commit 72829cb into khanlab:main Sep 25, 2023
5 checks passed
@kaitj kaitj deleted the maint/fix-docker branch September 25, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants