Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug custom gotInstance #49

Merged
merged 5 commits into from
Jul 31, 2020

Conversation

tiago154
Copy link
Contributor

@tiago154 tiago154 commented Jul 29, 2020

Description of the Change

Updates the got package to the latest version

Why Should This Be here?

A bug was reported due to the outdated version in the project

Benefits

Have compatibility with the new version of the package got

Possible Drawbacks

Here are some points of attention:

  • The runner function then had to be modified with special attention to the code review.
  • By the tests I performed, now when a request (got) returns with the status code between 4xx or 5xx, the code returns an exception, so I believe that it will be necessary to change the logic in this function here
  • When I updated the package, I had problems with the types that were previously in the project, so I made some changes to make the code work. Feel free to make suggestions.
  • The tests are not 100% covered, as I believe there are still changes to the runner file

Applicable Issues

#48

@khaosdoctor khaosdoctor linked an issue Jul 31, 2020 that may be closed by this pull request
@khaosdoctor khaosdoctor self-assigned this Jul 31, 2020
khaosdoctor added a commit that referenced this pull request Jul 31, 2020
@khaosdoctor khaosdoctor merged commit d1a00ab into khaosdoctor:main Jul 31, 2020
@tiago154 tiago154 deleted the fix/custom-gotInstance branch July 31, 2020 19:37
@khaosdoctor
Copy link
Owner

Thanks a lot @tiago154! Awesome work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Adding custom gotInstance results in error
2 participants