feat(catalog): Add istio-stack #110
Conversation
beiertu-mms
force-pushed
the
feat/add-istio-stack
branch
from
4e292b4
to
52a8314
Compare
beiertu-mms
force-pushed
the
feat/add-istio-stack
branch
2 times, most recently
from
1bd88e3
to
66f4699
Compare
beiertu-mms
force-pushed
the
feat/add-istio-stack
branch
6 times, most recently
from
46a53e6
to
b199e28
Compare
beiertu-mms
force-pushed
the
feat/add-istio-stack
branch
from
32f5365
to
4475955
Compare
| name: istio-apps-mtls | ||
| namespace: apps | ||
| spec: | ||
| host: "*.apps.svc.cluster.local" |
There was a problem hiding this comment.
what is apps? What if the customer doesn't have an apps namespace? Imo this is user specific configuration whcih you can't foresee
There was a problem hiding this comment.
maybe it can be removed and a howto on the readme can be added for enabling this feature?
There was a problem hiding this comment.
i think we shouldn't do it at all. This too opinionated. We just provide preconfiguration for istio based on where its running, but not how they should define their ingress/egress
beiertu-mms
force-pushed
the
feat/add-istio-stack
branch
from
1c1e0d2
to
288dc4f
Compare
beiertu-mms
force-pushed
the
feat/add-istio-stack
branch
from
698ab6a
to
73b524c
Compare
catalog/istio-stack/README.md
Outdated
| # istio-stack | ||
|
|
||
| This stack made it easier to setup a service mesh with [istio](https://istio.io/latest/). | ||
| It provides the setup for [istio-operator](https://github.com/stevehipwell/helm-charts/tree/master/charts/istio-operator) with sensible defaults |
There was a problem hiding this comment.
sorry, didnt see it before. I think this link is not the correct anymore?
There was a problem hiding this comment.
adjust this sentence
| enabled: true | ||
| is_core: false | ||
| grafana: | ||
| url: "http://kube-prometheus-stack-grafana.monitoring.svc.cluster.local" |
There was a problem hiding this comment.
| url: "http://kube-prometheus-stack-grafana.monitoring.svc.cluster.local" | |
| url: "http://prometheus-operator-grafana.monitoring.svc.cluster.local" |
| grafana: | ||
| url: "http://kube-prometheus-stack-grafana.monitoring.svc.cluster.local" | ||
| prometheus: | ||
| url: "http://kube-prometheus-stack-operator.monitoring.svc.cluster.local:9090" |
There was a problem hiding this comment.
| url: "http://kube-prometheus-stack-operator.monitoring.svc.cluster.local:9090" | |
| url: "http://prometheus-operated.monitoring.svc.cluster.local:9090" |
There was a problem hiding this comment.
for me kube-prometheus-stack-operator is the one, when kube-prometheus-stack is is in use. Currently we only have the kube-prometheus-stack in the catalog
| custom_dashboards: | ||
| enabled: true | ||
| is_core: false | ||
| grafana: |
There was a problem hiding this comment.
but probably extract the two urls in postBuild.subsitution to make it easy to override?
can one kustomization override the postBuild.subsitutions of another?
There was a problem hiding this comment.
good question, but you could also just patch the helmrelease via kustomize
There was a problem hiding this comment.
can one kustomization override the postBuild.subsitutions of another?
not sure, but probably not.
maybe we can take out these specific urls and let the user override them according to their setup?
There was a problem hiding this comment.
sure ;) postBuild.substitutions just would be simpler - but I also guess it won't work.
There was a problem hiding this comment.
if i want to overwrite something, I patch the HelmRelease
|
is it finished=? |
hm, think so, waiting for the resolution of the conversation about the grafana/prometheus links. |
For me its fine. People can override with kustomize patches |
See issue: