hashicorp#10381: fixes after review

khateeb15 · Feb 1, 2020 · 63d972d · 63d972d
1 parent bd69a76
commit 63d972d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/aws/resource_aws_datasync_location_smb.go b/aws/resource_aws_datasync_location_smb.go
@@ -36,6 +36,7 @@ func resourceAwsDataSyncLocationSmb() *schema.Resource {
 				Type:     schema.TypeString,
 				Computed: true,
 				Optional: true,
+				ForceNew: true,
 			},
 			"mount_options": {
 				Type:             schema.TypeList,
@@ -63,10 +64,12 @@ func resourceAwsDataSyncLocationSmb() *schema.Resource {
 				Type:      schema.TypeString,
 				Required:  true,
 				Sensitive: true,
+				ForceNew: true,
 			},
 			"server_hostname": {
 				Type:     schema.TypeString,
 				Required: true,
+				ForceNew: true,
 			},
 			"subdirectory": {
 				Type:     schema.TypeString,
@@ -92,6 +95,7 @@ func resourceAwsDataSyncLocationSmb() *schema.Resource {
 			"user": {
 				Type:     schema.TypeString,
 				Required: true,
+				ForceNew: true,
 			},
 		},
 	}

diff --git a/website/aws.erb b/website/aws.erb
@@ -793,6 +793,9 @@
                                 <li>
                                     <a href="/docs/providers/aws/r/datasync_location_s3.html">aws_datasync_location_s3</a>
                                 </li>
+                                <li>
+                                    <a href="/docs/providers/aws/r/datasync_location_smb.html">aws_datasync_location_smb</a>
+                                </li>
                                 <li>
                                     <a href="/docs/providers/aws/r/datasync_task.html">aws_datasync_task</a>
                                 </li>

diff --git a/website/docs/r/datasync_location_smb.html.markdown b/website/docs/r/datasync_location_smb.html.markdown
@@ -6,7 +6,7 @@ description: |-
   Manages an AWS DataSync SMB Location
 ---
 
-# Resource: aws_datasync_location_SMB
+# Resource: aws_datasync_location_smb
 
 Manages a SMB Location within AWS DataSync.
 
@@ -32,7 +32,7 @@ The following arguments are supported:
 
 * `agent_arns` - (Required) A list of DataSync Agent ARNs with which this location will be associated.
 * `domain` - (Optional) The name of the Windows domain the SMB server belongs to.
-* `mount_options` - (Optional) The mount options used by DataSync to access the SMB Server. Can be `AUTOMATIC`, `SMB2`, or `SMB3`.
+* `mount_options` - (Optional) Configuration block containing mount options used by DataSync to access the SMB Server. Documented below.
 * `password` - (Required) The password of the user who can mount the share and has file permissions in the SMB.
 * `server_hostname` - (Required) Specifies the IP address or DNS name of the SMB server. The DataSync Agent(s) use this to mount the SMB share.
 * `subdirectory` - (Required) Subdirectory to perform actions as source or destination. Should be exported by the NFS server.
@@ -41,9 +41,9 @@ The following arguments are supported:
 
 ### mount_options Argument Reference
 
-The following arguments are supported inside the `on_prem_config` configuration block:
+The following arguments are supported inside the `mount_options` configuration block:
 
-* `version` - (Optional) The specific SMB version that you want DataSync to use mounting your SMB share. Default: `AUTOMATIC`
+* `version` - (Optional) The specific SMB version that you want DataSync to use for mounting your SMB share. valid values: `AUTOMATIC`, `SMB2`, and `SMB3`. Default: `AUTOMATIC`
 
 ## Attribute Reference
 
@@ -53,7 +53,7 @@ In addition to all arguments above, the following attributes are exported:
 
 ## Import
 
-`aws_datasync_location_smb` can be imported by using the DataSync Task Amazon Resource Name (ARN), e.g.
+`aws_datasync_location_smb` can be imported by using the Amazon Resource Name (ARN), e.g.
 
 ```
 $ terraform import aws_datasync_location_smb.example arn:aws:datasync:us-east-1:123456789012:location/loc-12345678901234567