Fix generation of female FNR

khellang · Oct 18, 2023 · ef96770 · ef96770
1 parent 15fd55a
commit ef96770
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/Redskap/RandomExtensions.cs b/src/Redskap/RandomExtensions.cs
@@ -60,7 +60,7 @@ private static RandomRangeEnumerator GetRange(this Random random, Gender gender,
         // Adjust to an odd or even seed based on the specified gender:
         // - Female is even
         // - Male is odd
-        if (gender == Gender.Male && seed % 2 == 0)
+        if ((gender == Gender.Male) == (seed % 2 == 0))
         {
             seed = ++seed % count;
         }

diff --git a/test/Redskap.Tests/IdentificationNumberTests.cs b/test/Redskap.Tests/IdentificationNumberTests.cs
@@ -61,6 +61,24 @@ public void Full_Roundtrip()
         }
     }
 
+    [Fact]
+    public void Generate_With_Specification()
+    {
+        var gen = new Generator(new Random(123));
+        var earliest = DateTime.Now.AddYears(-80).Date;
+        var latest = DateTime.Now.AddYears(0).Date;
+        foreach (var gender in new[] { Gender.Female, Gender.Male })
+        {
+            for (var i = 0; i < 10_000; i++)
+            {
+                var generated = gen.Generate(Kind.FNumber, gender, earliest, latest);
+
+                Assert.InRange(generated.DateOfBirth, earliest, latest);
+                Assert.Equal(gender, generated.Gender);
+            }
+        }
+    }
+
     public class TestData
     {
         private TestData(string value, Gender gender, DateTime dateOfBirth, Kind kind)