- Fix issues #148 #117 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 13, 2021 23:25
|
@khellang, are these changes make sense for Scrutor rep? |
This was referenced Jan 28, 2022
|
Thanks for the PR @Mariachi1231! 🙏🏻 I've pushed v4.0.0 to NuGet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suppose to cover #148 #117. The problem was that decorable service was registered, most likely, as self. Which causing recursion according to a previous logic. Now, we are comparing the
ImplementationTypeandServiceTypeof the existing descriptors before decoration. If they are equal, this means that we cannot useActivatorUtilities.GetServiceOrCreateInstancein the new descriptor, and the factory for it should useActivatorUtilities.CreateInstance.Described issue covered in separate test
Issue148_Decorate_IsAbleToDecorateConcreateTypes.