Skip to content

bug: avoid page crash #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2022
Merged

bug: avoid page crash #34

merged 2 commits into from
Jun 30, 2022

Conversation

khiga8
Copy link
Owner

@khiga8 khiga8 commented Jun 30, 2022

This PR makes a couple of updates:

  • fix bug where page crashes when I go to Notifications from home page. This is a recent issue I've been noticing. I think there might be an infinite mutation loop happening when I go from GitHub home to Notifications. I am unable to hit a breakpoint when I try to debug, but adding observer.disconnect(); call within the callback fixes the issue.
  • adds an interval to debounce making the appendAccessibilityInfo updates
  • updates the selector we listen to from mutation.target.matches('.markdown-body') to mutation.target.closest('.markdown-body')

@khiga8 khiga8 merged commit 2e1c1fc into main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant