-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown Suggestions #37
Conversation
@@ -0,0 +1,3 @@ | |||
module.exports = { | |||
presets: [["@babel/preset-env", { targets: { node: "current" } }]], | |||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added for jest testing
devtools-feedback/devtools.js
Outdated
@@ -0,0 +1,2 @@ | |||
// Create a tab in the devtools area | |||
chrome.devtools.panels.create("GitHub Markdown a11y", "./devtools-feedback/toast.png", "./devtools-feedback/panel.html"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use "Mona's Markdown a11y" everywhere instead of "GitHub Markdown a11y"?
🎉 👏 🥳 |
This is so exciting! Thank you for opening this PR (and also adding tests) 👏! Some initial thoughts/questions!
|
Right now I am querying by textArea 🤔 -- because these pages have several hidden textAreas I have had to filter by hidden textAreas... I believe the when a user selects preview the textArea becomes hidden and therefore the textArea is removed from the validation list :/ .... We might be able to optimize this by adding an data attribute of some sort to edited textAreas in the future |
Thank you for catching this! I had these links styled so something might have gotten messed up let me fix 👩🎨 |
I think to avoid noise as the user is typing -- I don't want to provide feedback until the user is ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!!! Let's ship it!!!! 💪🚀
I would also recommend creating follow-up issues to document the future to-dos you listed! |
Markdown Accessibility dev-tools
I am working to create a markdown dev-tools validator. The validator will check any textArea that:
clientWidth=0
value != ''
Working Rules
Features:
A snippet of what the markdown dev-tools looks like:
Questions:
Future TODOS:
panel.css