Fixed #401 - Change the scope for deps

khmarbaise · Dec 20, 2023 · c7eaaaa · c7eaaaa
1 parent c0343f2
commit c7eaaaa
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 15 deletions.
diff --git a/itf-documentation/src/main/asciidoc/release-notes/_release-notes-0.13.0.adoc b/itf-documentation/src/main/asciidoc/release-notes/_release-notes-0.13.0.adoc
@@ -54,6 +54,7 @@
 :issue-398: https://github.com/khmarbaise/maven-it-extension/issues/398[Fixed #398]
 :issue-399: https://github.com/khmarbaise/maven-it-extension/issues/399[Fixed #399]
 :issue-401: https://github.com/khmarbaise/maven-it-extension/issues/401[Fixed #401]
+:issue-405: https://github.com/khmarbaise/maven-it-extension/issues/405[Fixed #405]
 :issue-??: https://github.com/khmarbaise/maven-it-extension/issues/??[Fixed #??]
 
 :release_0_13_0: https://github.com/khmarbaise/maven-it-extension/milestone/13
@@ -129,6 +130,7 @@
  * {issue-398} - Make Build working with JDK21.
  * {issue-401} - Upgrade Build Minimum to Maven 3.9.6
  * {issue-331} - Build failure with Maven 4.0.0-alpha-4
+ * {issue-405} - Change the scope for deps
 
 
 The full release notes can be found here {release_0_13_0}[Release 0.13.0].
diff --git a/itf-failure-plugin/pom.xml b/itf-failure-plugin/pom.xml
@@ -32,27 +32,32 @@
   <packaging>maven-plugin</packaging>
   <artifactId>itf-failure-plugin</artifactId>
 
+  <properties>
+    <mavenMinimumVersion>3.2.5</mavenMinimumVersion>
+  </properties>
   <dependencies>
     <dependency>
       <groupId>org.apache.maven</groupId>
       <artifactId>maven-model</artifactId>
-      <version>3.1.0</version>
+      <version>${mavenMinimumVersion}</version>
+      <scope>provided</scope>
     </dependency>
     <dependency>
       <groupId>org.apache.maven</groupId>
       <artifactId>maven-core</artifactId>
-      <version>3.1.0</version>
+      <version>${mavenMinimumVersion}</version>
+      <scope>provided</scope>
     </dependency>
     <dependency>
       <groupId>org.apache.maven</groupId>
       <artifactId>maven-plugin-api</artifactId>
+      <version>${mavenMinimumVersion}</version>
       <scope>provided</scope>
-      <version>3.1.0</version>
     </dependency>
     <dependency>
       <groupId>org.apache.maven.plugin-tools</groupId>
       <artifactId>maven-plugin-annotations</artifactId>
-      <version>3.6.0</version>
+      <version>${maven-plugin-plugin.version}</version>
       <scope>provided</scope>
     </dependency>
     <dependency>
@@ -115,7 +120,6 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-plugin-plugin</artifactId>
-        <version>3.6.0</version>
         <executions>
           <execution>
             <id>default-descriptor</id>

diff --git a/itf-maven-plugin/pom.xml b/itf-maven-plugin/pom.xml
@@ -34,7 +34,6 @@
 
   <properties>
     <mavenMinimumVersion>3.2.5</mavenMinimumVersion>
-    <maven.plugin.tool>3.6.4</maven.plugin.tool>
   </properties>
 
   <prerequisites>
@@ -72,6 +71,13 @@
       <version>${mavenMinimumVersion}</version>
       <scope>provided</scope>
     </dependency>
+    <!-- Need to reconsider this -->
+    <dependency>
+      <groupId>org.apache.maven</groupId>
+      <artifactId>maven-aether-provider</artifactId>
+      <version>${mavenMinimumVersion}</version>
+      <scope>provided</scope>
+    </dependency>
     <dependency>
       <groupId>org.codehaus.plexus</groupId>
       <artifactId>plexus-utils</artifactId>
@@ -82,12 +88,6 @@
       <artifactId>plexus-interpolation</artifactId>
       <version>1.26</version>
     </dependency>
-    <!-- Need to reconsider this -->
-    <dependency>
-      <groupId>org.apache.maven</groupId>
-      <artifactId>maven-aether-provider</artifactId>
-      <version>${mavenMinimumVersion}</version>
-    </dependency>
     <dependency>
       <groupId>org.apache.maven.shared</groupId>
       <artifactId>maven-filtering</artifactId>
@@ -101,7 +101,7 @@
     <dependency>
       <groupId>org.apache.maven.plugin-tools</groupId>
       <artifactId>maven-plugin-annotations</artifactId>
-      <version>${maven.plugin.tool}</version>
+      <version>${maven-plugin-plugin.version}</version>
       <scope>provided</scope>
     </dependency>
     <dependency>
@@ -143,7 +143,6 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-plugin-plugin</artifactId>
-        <version>${maven.plugin.tool}</version>
         <executions>
           <execution>
             <id>default-descriptor</id>

diff --git a/pom.xml b/pom.xml
@@ -62,6 +62,7 @@
     -->
     <trimStackTrace>false</trimStackTrace>
     <automatic-module-name>com.soebes.itf.extension</automatic-module-name>
+    <maven-plugin-plugin.version>3.10.2</maven-plugin-plugin.version>
   </properties>
 
   <dependencyManagement>
@@ -165,7 +166,7 @@
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-plugin-plugin</artifactId>
-          <version>3.10.2</version>
+          <version>${maven-plugin-plugin.version}</version>
         </plugin>
       </plugins>
     </pluginManagement>