Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnabledForMavenVersion / DisabledForMaven seemed to be not working #325

Closed
khmarbaise opened this issue Jan 15, 2023 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@khmarbaise
Copy link
Owner

khmarbaise commented Jan 15, 2023

Currently the usage seemed to be not working correctly to execute a test only for a particular Maven version. The following test is being executed on contradiction to the defined @DisabledForMavenVersion(MavenVersion.M3_8_7):

  @MavenTest
  @MavenProfile("unknown-profile")
  @DisabledForMavenVersion(MavenVersion.M3_8_7)
  void unknown_profile(MavenExecutionResult result) {
    assertThat(result)
        .isSuccessful()
        .out()
        .warn().containerExactly("The requested profile \"unknown-profile\" could not be activated because it does not exist.");
  }

Related to #327

@khmarbaise khmarbaise added the bug Something isn't working label Jan 15, 2023
@khmarbaise khmarbaise added this to the itf-extension-0.13.0 milestone Jan 15, 2023
@khmarbaise
Copy link
Owner Author

After a deeper analysis the issue. This is related to my smpp parent which defines a property <maven.version>3.8.4</maven.version> which will result in the problem.

@khmarbaise
Copy link
Owner Author

Closing it related to #421

khmarbaise added a commit that referenced this issue Dec 24, 2023
…different version combinations

 - This fixes also the issue #418 and #325
@khmarbaise khmarbaise self-assigned this Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant