This repository has been archived by the owner on Feb 4, 2023. It is now read-only.
Fix "blank new line in chunk" bug #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a chunk contains an empty line ("\r\n") chunkLength will be 0 and _setReadyState(readyStateDone) will be called, resulting in truncated payloads. We actually need to wait for "0\r\n" to set state as done.
|
HI @1618033 Thanks for the PR, which is merged now. Looking forward to receiving more of your bug-fixes and PRs Best Regards, |
|
Hi @1618033 The new AsyncHTTPRequest_Generic v1.12.0 has just been released. Your contribution is noted in Contributions and Thanks Best Regards, Releases v1.12.0
|
khoih-prog
added a commit
to khoih-prog/AsyncHTTPSRequest_Generic
that referenced
this pull request
Dec 1, 2022
### Releases v2.4.0 1. Add support to ESP32 boards using `LwIP W5500 Ethernet` 2. Fix bug. Check [Fix "blank new line in chunk" bug #50](khoih-prog/AsyncHTTPRequest_Generic#50)
khoih-prog
added a commit
to khoih-prog/AsyncHTTPSRequest_Generic
that referenced
this pull request
Dec 1, 2022
### Releases v2.4.0 1. Add support to ESP32 boards using `LwIP W5500 Ethernet` 2. Fix bug. Check [Fix "blank new line in chunk" bug #50](khoih-prog/AsyncHTTPRequest_Generic#50)
khoih-prog
added a commit
to khoih-prog/AsyncHTTPSRequest_Generic
that referenced
this pull request
Dec 1, 2022
### Releases v2.4.0 1. Add support to ESP32 boards using `LwIP W5500 Ethernet` 2. Fix bug. Check [Fix "blank new line in chunk" bug #50](khoih-prog/AsyncHTTPRequest_Generic#50)
khoih-prog
added a commit
to khoih-prog/AsyncHTTPSRequest_Generic
that referenced
this pull request
Dec 1, 2022
### Releases v2.4.0 1. Add support to ESP32 boards using `LwIP W5500 Ethernet` 2. Fix bug. Check [Fix "blank new line in chunk" bug #50](khoih-prog/AsyncHTTPRequest_Generic#50)
khoih-prog
added a commit
to khoih-prog/AsyncHTTPSRequest_Generic
that referenced
this pull request
Dec 1, 2022
### Releases v2.4.0 1. Add support to ESP32 boards using `LwIP W5500 Ethernet` 2. Fix bug. Check [Fix "blank new line in chunk" bug #50](khoih-prog/AsyncHTTPRequest_Generic#50)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a chunk contains an empty line ("\r\n") chunkLength will be 0 and _setReadyState(readyStateDone) will be called, resulting in truncated payloads. We actually need to wait for "0\r\n" to set state as done.