Skip to content
This repository has been archived by the owner on Jan 29, 2023. It is now read-only.

v1.2.5: Compilation broken due to error in STM32AsyncTCP dependency #4

Closed
dl1com opened this issue Mar 22, 2021 · 2 comments
Closed
Labels
bug Something isn't working enhancement New feature or request

Comments

@dl1com
Copy link

dl1com commented Mar 22, 2021

Description

As already described in #2 by @jcw, there is an issue with the external dependency of the STM32AsyncTCP Library.
In the current version (1.2.5) of AsyncWebServer_STM32, compilation fails with just the same error as described in #2, as the root of the cause is still not fixed upstream, the library.json of the library still states the wrong platform ( "platforms": "espressif8266", https://github.com/philbowles/STM32AsyncTCP/blob/master/library.json#L18).

Workaround

To get my setup working, I just refer to your fork of the library in my platform.ini, as your fork already contains the relevant fix:

lib_deps =
    STM32AsyncTCP=https://github.com/khoih-prog/STM32AsyncTCP
    khoih.prog/AsyncWebServer_STM32@^1.2.5

Short-Term Solution

I'd propose that you alter your library.json to point to your fork of the lib (https://github.com/khoih-prog/AsyncWebServer_STM32/blob/master/library.json#L42) until it is fixed upstream.

Please let me know if I shall supply this as a PR, I am happy to do so.

Long-Term solution

PR the relevant fixes in the upstream repo of philbowles.

khoih-prog added a commit that referenced this issue Mar 22, 2021
### Releases v1.2.6

1. Fix dependency on unpublished [**STM32AsyncTCP Library**](https://github.com/philbowles/STM32AsyncTCP). Check [Compilation broken due to error in STM32AsyncTCP dependency](#4) and [how to run one of the examples?](#2).
khoih-prog added a commit that referenced this issue Mar 22, 2021
### Releases v1.2.6

1. Fix dependency on unpublished [**STM32AsyncTCP Library**](https://github.com/philbowles/STM32AsyncTCP). Check [Compilation broken due to error in STM32AsyncTCP dependency](#4) and [how to run one of the examples?](#2).
@khoih-prog
Copy link
Owner

Hi @chris007de

Thanks for your contribution. As the issue is spanning across several libraries, I have to take over to modify and release the new version.

Your and Jean-Claude contributions have been noted in Contributions and Thanks

Please check to see if there still any other issue.


Releases v1.2.6

  1. Fix dependency on unpublished STM32AsyncTCP Library. Check Compilation broken due to error in STM32AsyncTCP dependency and how to run one of the examples?.

@khoih-prog khoih-prog added bug Something isn't working enhancement New feature or request labels Mar 22, 2021
khoih-prog added a commit to khoih-prog/AsyncHTTPRequest_Generic that referenced this issue Mar 23, 2021
### Releases v1.1.5

1. Fix dependency on unpublished [**STM32AsyncTCP Library**](https://github.com/philbowles/STM32AsyncTCP). Check [Compilation broken due to error in STM32AsyncTCP dependency](khoih-prog/AsyncWebServer_STM32#4) and [how to run one of the examples?](khoih-prog/AsyncWebServer_STM32#2).
khoih-prog added a commit that referenced this issue Mar 23, 2021
### Releases v1.2.6

1. Fix dependency on unpublished [**STM32AsyncTCP Library**](https://github.com/philbowles/STM32AsyncTCP). Check [Compilation broken due to error in STM32AsyncTCP dependency](#4) and [how to run one of the examples?](#2).
khoih-prog added a commit to khoih-prog/AsyncHTTPRequest_Generic that referenced this issue Mar 23, 2021
### Releases v1.1.5

1. Fix dependency on unpublished [**STM32AsyncTCP Library**](https://github.com/philbowles/STM32AsyncTCP). Check [Compilation broken due to error in STM32AsyncTCP dependency](khoih-prog/AsyncWebServer_STM32#4) and [how to run one of the examples?](khoih-prog/AsyncWebServer_STM32#2).
@dl1com
Copy link
Author

dl1com commented Mar 23, 2021

Thanks a lot, it's fixed with v1.2.6.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants