v1.4.1

### Releases v1.4.1 1. Fix bug. 2. Fix compiler warnings.
khoih-prog · Dec 22, 2020 · 5a3aa22 · 5a3aa22
1 parent db9fe2c
commit 5a3aa22
Show file tree

Hide file tree

Showing 19 changed files with 123 additions and 99 deletions.
diff --git a/examples/Async_AutoConnect/Async_AutoConnect.ino b/examples/Async_AutoConnect/Async_AutoConnect.ino
@@ -13,7 +13,7 @@
 
   Built by Khoi Hoang https://github.com/khoih-prog/ESPAsync_WiFiManager
   Licensed under MIT license
-  Version: 1.4.0
+  Version: 1.4.1
 
   Version Modified By  Date      Comments
   ------- -----------  ---------- -----------
@@ -25,6 +25,7 @@
   1.2.0   K Hoang      15/10/2020 Restore cpp code besides Impl.h code to use if linker error. Fix bug.
   1.3.0   K Hoang      04/12/2020 Add LittleFS support to ESP32 using LITTLEFS Library
   1.4.0   K Hoang      18/12/2020 Fix staticIP not saved. Add functions. Add complex examples.
+  1.4.1   K Hoang      21/12/2020 Fix bug and compiler warnings.
  *****************************************************************************************************************************/
 #if !( defined(ESP8266) ||  defined(ESP32) )
   #error This code is intended to run on the ESP8266 or ESP32 platform! Please check your Tools->Board setting.
@@ -34,10 +35,10 @@
 #define _ESPASYNC_WIFIMGR_LOGLEVEL_    3
 
 // Default is 30s, using 20s now
-#define TIME_BETWEEN_MODAL_SCANS          20000
+#define TIME_BETWEEN_MODAL_SCANS          20000UL
 
 // Default is 60s, using 30s now
-#define TIME_BETWEEN_MODELESS_SCANS       30000
+#define TIME_BETWEEN_MODELESS_SCANS       30000UL
 
 //Ported to ESP32
 #ifdef ESP32
@@ -421,10 +422,11 @@ void loadConfigData()
   File file = FileFS.open(CONFIG_FILENAME, "r");
   LOGERROR(F("LoadWiFiCfgFile "));
 
-  memset(&WM_config,   sizeof(WM_config), 0);
+  memset(&WM_config,       0, sizeof(WM_config));
 
   // New in v1.4.0
-  memset(&WM_STA_IPconfig, sizeof(WM_STA_IPconfig), 0);
+  memset(&WM_STA_IPconfig, 0, sizeof(WM_STA_IPconfig));
+  //////
   //////
 
   if (file)

diff --git a/examples/Async_AutoConnectWithFSParameters/Async_AutoConnectWithFSParameters.ino b/examples/Async_AutoConnectWithFSParameters/Async_AutoConnectWithFSParameters.ino
@@ -13,7 +13,7 @@
 
   Built by Khoi Hoang https://github.com/khoih-prog/ESPAsync_WiFiManager
   Licensed under MIT license
-  Version: 1.3.0
+  Version: 1.4.1
 
   Version Modified By  Date      Comments
   ------- -----------  ---------- -----------
@@ -24,6 +24,8 @@
   1.1.2   K Hoang      17/09/2020 Fix bug in examples.
   1.2.0   K Hoang      15/10/2020 Restore cpp code besides Impl.h code to use if linker error. Fix bug.
   1.3.0   K Hoang      04/12/2020 Add LittleFS support to ESP32 using LITTLEFS Library
+  1.4.0   K Hoang      18/12/2020 Fix staticIP not saved. Add functions. Add complex examples.
+  1.4.1   K Hoang      21/12/2020 Fix bug and compiler warnings.
  *****************************************************************************************************************************/
 #if !( defined(ESP8266) ||  defined(ESP32) )
   #error This code is intended to run on the ESP8266 or ESP32 platform! Please check your Tools->Board setting.
@@ -33,10 +35,10 @@
 #define _ESPASYNC_WIFIMGR_LOGLEVEL_    3
 
 // Default is 30s, using 20s now
-#define TIME_BETWEEN_MODAL_SCANS          20000
+#define TIME_BETWEEN_MODAL_SCANS          20000UL
 
 // Default is 60s, using 30s now
-#define TIME_BETWEEN_MODELESS_SCANS       30000
+#define TIME_BETWEEN_MODELESS_SCANS       30000UL
 
 #include <FS.h>
 
@@ -529,6 +531,8 @@ bool saveFileFSConfigFile()
   if (!configFile)
   {
     Serial.println("Failed to open config file for writing");
+
+    return false;
   }
 
 #if (ARDUINOJSON_VERSION_MAJOR >= 6)
@@ -545,6 +549,8 @@ bool saveFileFSConfigFile()
 
   configFile.close();
   //end save
+
+  return true;
 }
 
 void toggleLED()
@@ -623,10 +629,10 @@ void loadConfigData()
   File file = FileFS.open(CONFIG_FILENAME, "r");
   LOGERROR(F("LoadWiFiCfgFile "));
 
-  memset(&WM_config,   sizeof(WM_config), 0);
+  memset(&WM_config,       0, sizeof(WM_config));
 
   // New in v1.4.0
-  memset(&WM_STA_IPconfig, sizeof(WM_STA_IPconfig), 0);
+  memset(&WM_STA_IPconfig, 0, sizeof(WM_STA_IPconfig));
   //////
 
   if (file)

diff --git a/...c_AutoConnectWithFSParametersAndCustomIP/Async_AutoConnectWithFSParametersAndCustomIP.ino b/...c_AutoConnectWithFSParametersAndCustomIP/Async_AutoConnectWithFSParametersAndCustomIP.ino
@@ -13,7 +13,7 @@
 
   Built by Khoi Hoang https://github.com/khoih-prog/ESPAsync_WiFiManager
   Licensed under MIT license
-  Version: 1.4.0
+  Version: 1.4.1
 
   Version Modified By  Date      Comments
   ------- -----------  ---------- -----------
@@ -24,7 +24,8 @@
   1.1.2   K Hoang      17/09/2020 Fix bug in examples.
   1.2.0   K Hoang      15/10/2020 Restore cpp code besides Impl.h code to use if linker error. Fix bug.
   1.3.0   K Hoang      04/12/2020 Add LittleFS support to ESP32 using LITTLEFS Library
-  1.4.0   K Hoang      18/12/2020 Fix staticIP not saved. Add functions. Add complex examples. 
+  1.4.0   K Hoang      18/12/2020 Fix staticIP not saved. Add functions. Add complex examples.
+  1.4.1   K Hoang      21/12/2020 Fix bug and compiler warnings.
  *****************************************************************************************************************************/
 
 #if !( defined(ESP8266) ||  defined(ESP32) )
@@ -35,10 +36,10 @@
 #define _ESPASYNC_WIFIMGR_LOGLEVEL_       3
 
 // Default is 30s, using 20s now
-#define TIME_BETWEEN_MODAL_SCANS          20000
+#define TIME_BETWEEN_MODAL_SCANS          20000UL
 
 // Default is 60s, using 30s now
-#define TIME_BETWEEN_MODELESS_SCANS       30000
+#define TIME_BETWEEN_MODELESS_SCANS       30000UL
 
 #include <FS.h>                   //this needs to be first, or it all crashes and burns...
 
@@ -469,10 +470,10 @@ void loadConfigData()
   File file = FileFS.open(CONFIG_FILENAME, "r");
   LOGERROR(F("LoadWiFiCfgFile "));
 
-  memset(&WM_config,   sizeof(WM_config), 0);
+  memset(&WM_config,       0, sizeof(WM_config));
 
   // New in v1.4.0
-  memset(&WM_STA_IPconfig, sizeof(WM_STA_IPconfig), 0);
+  memset(&WM_STA_IPconfig, 0, sizeof(WM_STA_IPconfig));
   //////
 
   if (file)

diff --git a/examples/Async_AutoConnectWithFeedback/Async_AutoConnectWithFeedback.ino b/examples/Async_AutoConnectWithFeedback/Async_AutoConnectWithFeedback.ino
@@ -13,7 +13,7 @@
 
   Built by Khoi Hoang https://github.com/khoih-prog/ESPAsync_WiFiManager
   Licensed under MIT license
-  Version: 1.4.0
+  Version: 1.4.1
 
   Version Modified By  Date      Comments
   ------- -----------  ---------- -----------
@@ -25,6 +25,7 @@
   1.2.0   K Hoang      15/10/2020 Restore cpp code besides Impl.h code to use if linker error. Fix bug.
   1.3.0   K Hoang      04/12/2020 Add LittleFS support to ESP32 using LITTLEFS Library
   1.4.0   K Hoang      18/12/2020 Fix staticIP not saved. Add functions. Add complex examples.
+  1.4.1   K Hoang      21/12/2020 Fix bug and compiler warnings.
  *****************************************************************************************************************************/
 #if !( defined(ESP8266) ||  defined(ESP32) )
   #error This code is intended to run on the ESP8266 or ESP32 platform! Please check your Tools->Board setting.
@@ -34,10 +35,10 @@
 #define _ESPASYNC_WIFIMGR_LOGLEVEL_    3
 
 // Default is 30s, using 20s now
-#define TIME_BETWEEN_MODAL_SCANS          20000
+#define TIME_BETWEEN_MODAL_SCANS          20000UL
 
 // Default is 60s, using 30s now
-#define TIME_BETWEEN_MODELESS_SCANS       30000
+#define TIME_BETWEEN_MODELESS_SCANS       30000UL
 
 //Ported to ESP32
 #ifdef ESP32
@@ -425,10 +426,10 @@ void loadConfigData()
   File file = FileFS.open(CONFIG_FILENAME, "r");
   LOGERROR(F("LoadWiFiCfgFile "));
 
-  memset(&WM_config,   sizeof(WM_config), 0);
+  memset(&WM_config,       0, sizeof(WM_config));
 
   // New in v1.4.0
-  memset(&WM_STA_IPconfig, sizeof(WM_STA_IPconfig), 0);
+  memset(&WM_STA_IPconfig, 0, sizeof(WM_STA_IPconfig));
   //////
 
   if (file)

diff --git a/examples/Async_AutoConnectWithFeedbackLED/Async_AutoConnectWithFeedbackLED.ino b/examples/Async_AutoConnectWithFeedbackLED/Async_AutoConnectWithFeedbackLED.ino
@@ -13,7 +13,7 @@
 
   Built by Khoi Hoang https://github.com/khoih-prog/ESPAsync_WiFiManager
   Licensed under MIT license
-  Version: 1.4.0
+  Version: 1.4.1
 
   Version Modified By  Date      Comments
   ------- -----------  ---------- -----------
@@ -25,6 +25,7 @@
   1.2.0   K Hoang      15/10/2020 Restore cpp code besides Impl.h code to use if linker error. Fix bug.
   1.3.0   K Hoang      04/12/2020 Add LittleFS support to ESP32 using LITTLEFS Library
   1.4.0   K Hoang      18/12/2020 Fix staticIP not saved. Add functions. Add complex examples.
+  1.4.1   K Hoang      21/12/2020 Fix bug and compiler warnings.
  *****************************************************************************************************************************/
 #if !( defined(ESP8266) ||  defined(ESP32) )
   #error This code is intended to run on the ESP8266 or ESP32 platform! Please check your Tools->Board setting.
@@ -34,10 +35,10 @@
 #define _ESPASYNC_WIFIMGR_LOGLEVEL_    3
 
 // Default is 30s, using 20s now
-#define TIME_BETWEEN_MODAL_SCANS          20000
+#define TIME_BETWEEN_MODAL_SCANS          20000UL
 
 // Default is 60s, using 30s now
-#define TIME_BETWEEN_MODELESS_SCANS       30000
+#define TIME_BETWEEN_MODELESS_SCANS       30000UL
 
 //Ported to ESP32
 #ifdef ESP32
@@ -456,10 +457,11 @@ void loadConfigData()
   File file = FileFS.open(CONFIG_FILENAME, "r");
   LOGERROR(F("LoadWiFiCfgFile "));
 
-  memset(&WM_config,   sizeof(WM_config), 0);
+  memset(&WM_config,       0, sizeof(WM_config));
 
   // New in v1.4.0
-  memset(&WM_STA_IPconfig, sizeof(WM_STA_IPconfig), 0);
+  memset(&WM_STA_IPconfig, 0, sizeof(WM_STA_IPconfig));
+  //////
   //////
 
   if (file)

diff --git a/examples/Async_ConfigOnDRD_FS_MQTT_Ptr/Async_ConfigOnDRD_FS_MQTT_Ptr.ino b/examples/Async_ConfigOnDRD_FS_MQTT_Ptr/Async_ConfigOnDRD_FS_MQTT_Ptr.ino
@@ -13,7 +13,7 @@
 
   Built by Khoi Hoang https://github.com/khoih-prog/ESPAsync_WiFiManager
   Licensed under MIT license
-  Version: 1.4.0
+  Version: 1.4.1
 
   Version Modified By  Date      Comments
   ------- -----------  ---------- -----------
@@ -25,6 +25,7 @@
   1.2.0   K Hoang      15/10/2020 Restore cpp code besides Impl.h code to use if linker error. Fix bug.
   1.3.0   K Hoang      04/12/2020 Add LittleFS support to ESP32 using LITTLEFS Library
   1.4.0   K Hoang      18/12/2020 Fix staticIP not saved. Add functions. Add complex examples.
+  1.4.1   K Hoang      21/12/2020 Fix bug and compiler warnings.
  *****************************************************************************************************************************/
 /****************************************************************************************************************************
   This example will open a Config Portal when there is no stored WiFi Credentials or when a DRD is detected.
@@ -47,10 +48,10 @@
 #define _ESPASYNC_WIFIMGR_LOGLEVEL_    3
 
 // Default is 30s, using 20s now
-#define TIME_BETWEEN_MODAL_SCANS          20000
+#define TIME_BETWEEN_MODAL_SCANS          20000UL
 
 // Default is 60s, using 30s now
-#define TIME_BETWEEN_MODELESS_SCANS       30000
+#define TIME_BETWEEN_MODELESS_SCANS       30000UL
 
 #include <FS.h>
 
@@ -593,10 +594,10 @@ void loadConfigData()
   File file = FileFS.open(CONFIG_FILENAME, "r");
   LOGERROR(F("LoadWiFiCfgFile "));
 
-  memset(&WM_config,   sizeof(WM_config), 0);
+  memset(&WM_config,       0, sizeof(WM_config));
 
   // New in v1.4.0
-  memset(&WM_STA_IPconfig, sizeof(WM_STA_IPconfig), 0);
+  memset(&WM_STA_IPconfig, 0, sizeof(WM_STA_IPconfig));
   //////
 
   if (file)

diff --git a/examples/Async_ConfigOnDRD_FS_MQTT_Ptr_Complex/Async_ConfigOnDRD_FS_MQTT_Ptr_Complex.ino b/examples/Async_ConfigOnDRD_FS_MQTT_Ptr_Complex/Async_ConfigOnDRD_FS_MQTT_Ptr_Complex.ino
@@ -13,7 +13,7 @@
 
   Built by Khoi Hoang https://github.com/khoih-prog/ESPAsync_WiFiManager
   Licensed under MIT license
-  Version: 1.4.0
+  Version: 1.4.1
 
   Version Modified By  Date      Comments
   ------- -----------  ---------- -----------
@@ -25,6 +25,7 @@
   1.2.0   K Hoang      15/10/2020 Restore cpp code besides Impl.h code to use if linker error. Fix bug.
   1.3.0   K Hoang      04/12/2020 Add LittleFS support to ESP32 using LITTLEFS Library
   1.4.0   K Hoang      18/12/2020 Fix staticIP not saved. Add functions. Add complex examples.
+  1.4.1   K Hoang      21/12/2020 Fix bug and compiler warnings.
  *****************************************************************************************************************************/
 /****************************************************************************************************************************
   This example will open a Config Portal when there is no stored WiFi Credentials or when a DRD is detected.
@@ -47,10 +48,10 @@
 #define _ESPASYNC_WIFIMGR_LOGLEVEL_    3
 
 // Default is 30s, using 20s now
-#define TIME_BETWEEN_MODAL_SCANS          20000
+#define TIME_BETWEEN_MODAL_SCANS          20000UL
 
 // Default is 60s, using 30s now
-#define TIME_BETWEEN_MODELESS_SCANS       30000
+#define TIME_BETWEEN_MODELESS_SCANS       30000UL
 
 #include <FS.h>
 
@@ -643,10 +644,10 @@ void loadConfigData()
   File file = FileFS.open(CONFIG_FILENAME, "r");
   LOGERROR(F("LoadWiFiCfgFile "));
 
-  memset(&WM_config,   sizeof(WM_config), 0);
+  memset(&WM_config,       0, sizeof(WM_config));
 
   // New in v1.4.0
-  memset(&WM_STA_IPconfig, sizeof(WM_STA_IPconfig), 0);
+  memset(&WM_STA_IPconfig, 0, sizeof(WM_STA_IPconfig));
   //////
 
   if (file)