Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Resend sender email hardcoded to noreply@khoj.dev #908

Closed
4 tasks done
kanya-approve opened this issue Sep 12, 2024 · 1 comment · Fixed by #907
Closed
4 tasks done

[FIX] Resend sender email hardcoded to noreply@khoj.dev #908

kanya-approve opened this issue Sep 12, 2024 · 1 comment · Fixed by #907
Labels
fix Fix something that isn't working as expected

Comments

@kanya-approve
Copy link
Contributor

Describe the bug

When attempting to send magic login emails, noreply@khoj.dev is used which caused the email to fail as this domain is not configured on my Resend account. I expected the system to use an email from my domain, but it was hard coded to noreply@khoj.dev.

To Reproduce

Steps to reproduce the behavior:

  1. Attempt to log in using the magic login link via the web browser.
  2. The system tries to send an email using noreply@khoj.dev, which fails this email address is not associated with my Resend account.

Screenshots

N/A

Platform

  • Server:
    • Self-Hosted Docker
  • Client:
    • Web browser
  • OS:
    • Windows (Client)
    • Linux (Server)

If self-hosted

  • Server Version: 1.21.6

Additional context

N/A
@kanya-approve kanya-approve added the fix Fix something that isn't working as expected label Sep 12, 2024
@kanya-approve kanya-approve changed the title [FIX] [FIX] Resend sender email hardcoded to noreply@khoj.dev Sep 12, 2024
@kanya-approve
Copy link
Contributor Author

kanya-approve commented Sep 12, 2024 •
edited
Loading

@sabaimran @debanjum @MythicalCow

@kanya-approve kanya-approve mentioned this issue Sep 12, 2024
Merged
debanjum pushed a commit that referenced this issue Sep 13, 2024
@kanya-approve
Use environment variable to set sender email of auth link emails (#907)
1d512b4 
Set sender email using `RESEND_EMAIL` environment variable for magic link sent via Resend API for authentication . It was previously hard-coded. This prevented hosting Khoj on other domains. 

Resolves #908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix Fix something that isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use environment variable to set sender email of auth link emails
1 participant
@kanya-approve