Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Issue indexing from Obsidian on Windows #984

Closed
sabaimran opened this issue Nov 19, 2024 · 0 comments · Fixed by #993
Closed

[FIX] Issue indexing from Obsidian on Windows #984

sabaimran opened this issue Nov 19, 2024 · 0 comments · Fixed by #993
Labels
fix Fix something that isn't working as expected

Comments

@sabaimran
Copy link
Member

See the full report here.

Full stack trace:
powershellOutput.txt
@sabaimran sabaimran added the fix Fix something that isn't working as expected label Nov 19, 2024
debanjum added a commit that referenced this issue Dec 2, 2024
@debanjum
Do not wrap filepath in Path to fix indexing markdown files on Windows
dffdd81 
Issue
- Path with / are converted to \\ on Windows using the Path operator.
- The markdown to entries method for some reason was doing this.
  This would store the file paths in DB entry differently than the file
  to entries map. Resulting in a KeyError when trying to look up the
  entry file path from file_to_text_map in the
  text_to_entries:update_embeddings() function.

Fix
- Removing the unnecessary OS dependendent Path normalization in
  markdown_to_entries should keep the file path storage consistent
  across file_to_text_map var, FileObjectAdaptor, Entry DB tables on
  Windows for Markdown files as well

This issue would only affect users hosting Khoj server on Windows and
attempting to index markdown files.

Resolves #984
@debanjum debanjum mentioned this issue Dec 2, 2024
Merged
debanjum added a commit that referenced this issue Dec 2, 2024
@debanjum
Do not wrap filepath in Path to fix indexing markdown files on Windows (
db29894 
#993)

### Issue
- Path with / are converted to \\ on Windows using the `Path' operator.
- The `markdown_to_entries' module was trying to normalize file paths with`Path'  for some reason.
  This would store the file paths in DB Entry differently than the file to entries map if Khoj ran on Windows.
  That'd result in a KeyError when trying to look up the entry file path from `file_to_text_map' in the `text_to_entries:update_embeddings()' function.

### Fix
- Removing the unnecessary OS dependent Path normalization in `markdown_to_entries' should keep the file path storage consistent across `file_to_text_map' var, `FileObjectAdaptor', `Entry' DB tables on Windows for Markdown files as well.

This issue will affect users hosting Khoj server on Windows and attempting to index markdown files.

Resolves #984
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix Fix something that isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not wrap filepath in Path to fix indexing markdown files on Windows khoj-ai/khoj
1 participant
@sabaimran