Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new shadcn sidebar across all pages in Khoj #1013

Merged
merged 9 commits into from
Dec 24, 2024

Conversation

sabaimran
Copy link
Member

Use the shadcn sidebar across Khoj and standardize how the side panel experience works across the app. This helps us generalize the code better, while re-using the same components.

Deprecates current usage of the chat history side panel, replacing it with the new appSidebar.tsx component.

We'll eventually move out the Manage Files section and move it into a separate panel dedicated to chat-level controls.

- Use the sidebar across all pages to quickly navigate through the app, access settings, and go to past chats
- Pending: mobile friendliness
@sabaimran sabaimran requested a review from debanjum December 20, 2024 05:38
@sabaimran sabaimran added the upgrade New feature or request label Dec 20, 2024
Copy link
Member

@debanjum debanjum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so much nicer and consistent than our previous sidebar and page layout! ❤️. Left some comments mostly around non-logged in experience. But most of the stuff looks neat

src/interface/web/app/settings/page.tsx Show resolved Hide resolved
src/interface/web/app/chat/page.tsx Show resolved Hide resolved
src/interface/web/app/page.tsx Show resolved Hide resolved
src/interface/web/app/automations/page.tsx Show resolved Hide resolved
src/interface/web/app/search/page.tsx Show resolved Hide resolved
src/interface/web/app/agents/page.tsx Show resolved Hide resolved
Copy link
Member

@debanjum debanjum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes look good!

@sabaimran sabaimran merged commit 3e6ba45 into master Dec 24, 2024
7 checks passed
@sabaimran sabaimran deleted the features/use-sidebar branch December 24, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upgrade New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants