Add support for Anthropic models #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Had to use a custom class because there was enough nuance with how the anthropic SDK works that it would be better to simply separate out the logic. The extract questions flow needed modification of the system prompt in order to work as intended with the haiku model
… passing for tokens, system prompt
sabaimran
force-pushed
the
features/integrate-anthropic-claude
branch
from
cd3fb4d to
0e43157
Compare
debanjum
approved these changes
May 27, 2024
| @@ -542,8 +561,7 @@ def send_message_to_model_wrapper_sync( | |||
| ) | |||
|
|
|||
| elif conversation_config.model_type == "openai": | |||
| openai_chat_config = ConversationAdapters.get_openai_conversation_config() | |||
| api_key = openai_chat_config.api_key | |||
| api_key = conversation_config.openai_config.api_key | |||
There was a problem hiding this comment.
Should we rename openai_config to something more generic, e.g online_model?
Suggested change
| api_key = conversation_config.openai_config.api_key | |
| api_key = conversation_config.online_model.api_key |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incoming
Long-time coming, add first-party support for using Anthropic models inside the Khoj codebase. I went with a first-party approach (instead of leveraging an OpenAI-API compatible server, for instance) because the Anthropic models have slight nuances in the way messages are handled. For example, the first message to the model always has to be a user message. It is also less good at honoring the prompt output format when it's intended to be JSON.
Closes #760