Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Intermediate Steps in Formulating Chat Response #799

Merged
merged 4 commits into from
Jun 9, 2024

Conversation

debanjum
Copy link
Member

@debanjum debanjum commented Jun 6, 2024

Major

  • f91cdf8 Fix showing headings in intermediate step in generating chat response

  • 18f7e6e Remove "Path" prefix from org ancestor heading in compiled entry

  • dd2225b Use Text output mode to disambiguate from Default data source lookup
    Previously if default output was selected by Khoj, we'd end up doing
    a documents search as well, even when Khoj selected internet or
    general data source to lookup.

    This update disambiguates the default information mode from the text
    output mode. To avoid doing documents search when not deemed necessary
    by Khoj

Minor

  • Fix openai chat actor, director unit tests

debanjum added 3 commits June 6, 2024 11:56
Previously if default output was selected by Khoj, we'd end up doing
an documents search as well, even when Khoj selected internet or
general data source to lookup.

This update disambiguates the default information mode from the text
output mode. To avoid doing documents search when not deemed necessary
by Khoj
Copy link
Member

@sabaimran sabaimran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix, that bug was pretty annoying.

src/khoj/routers/api_chat.py Show resolved Hide resolved
- Update test ChatModelOptions setup since update to it's schema
- Fix stale function calls using their updated signatures
@debanjum debanjum merged commit 6afbd80 into master Jun 9, 2024
7 checks passed
@debanjum debanjum deleted the improve-intermediate-steps-in-chat-response branch June 9, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants