Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Google's Gemini model series #902

Merged
merged 16 commits into from
Sep 13, 2024
Merged

Support Google's Gemini model series #902

merged 16 commits into from
Sep 13, 2024

Conversation

aam-at
Copy link
Contributor

@aam-at aam-at commented Sep 4, 2024

This pull request adds support for Goggle Gemini AI models with extremely large context window which might be helpful for notes assistant.

debanjum
debanjum reviewed Sep 10, 2024
View reviewed changes
src/khoj/processor/conversation/gemini/utils.py Outdated Show resolved Hide resolved
src/khoj/routers/helpers.py Outdated Show resolved Hide resolved
@sabaimran
Copy link
Member

Thanks for creating this PR, @aam-at ! It's super valuable and helpful. Code quality is neat, and it worked for me with minimal configuration within the current setup.

I'll take care of the merge conflicts, and we should have this deployed sometime this week 🙂 .

@sabaimran sabaimran changed the title New Feature: Gemini Support for Khoj Add support for Gemini in ChatModelOption Sep 12, 2024
@debanjum debanjum changed the title Add support for Gemini in ChatModelOption Support Google's Gemini model series Sep 12, 2024
@debanjum debanjum added upgrade New feature or request coverage Add content type to search and index labels Sep 13, 2024
@debanjum
Add standard stop sequence for Gemini chat response generation
2649a81 
- Remove redundant thread close as it is done in the finally code block
- Use enum for missed model_type comparison
- Remove unused imports
@debanjum debanjum merged commit 9570933 into khoj-ai:master Sep 13, 2024
6 checks passed
@aam-at
Copy link
Contributor Author

aam-at commented Sep 13, 2024

@sabaimran @debanjum thanks for finalizing this pull request! :)

@sabaimran sabaimran mentioned this pull request Sep 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debanjum debanjum debanjum left review comments

Assignees
No one assigned
Labels
coverage Add content type to search and index upgrade New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aam-at @sabaimran @debanjum