Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compose-tests.yml #183

Merged
merged 9 commits into from
Nov 29, 2024
Merged

Update compose-tests.yml #183

merged 9 commits into from
Nov 29, 2024

Conversation

NxPKG
Copy link
Contributor

@NxPKG NxPKG commented Nov 29, 2024

User description

(Please add to the PR name the issue/s that this PR would close if merged by using a Github keyword. Example: <feature name>. Closes #999. If your PR is made by a single commit, please add that clause in the commit too. This is all required to automate the closure of related issues.)

Description

Please include a summary of the change and link to the related issue.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist

  • I have read and understood the rules about how to Contribute to this project
  • The pull request is for the branch develop
  • A new plugin (analyzer, connector, visualizer, playbook, pivot or ingestor) was added or changed, in which case:
    • I strictly followed the documentation "How to create a Plugin"
    • Usage file was updated.
    • Advanced-Usage was updated (in case the plugin provides additional optional configuration).
    • I have dumped the configuration from Django Admin using the dumpplugin command and added it in the project as a data migration. ("How to share a plugin with the community")
    • If a File analyzer was added and it supports a mimetype which is not already supported, you added a sample of that type inside the archive test_files.zip and you added the default tests for that mimetype in test_classes.py.
    • If you created a new analyzer and it is free (does not require any API key), please add it in the FREE_TO_USE_ANALYZERS playbook by following this guide.
    • Check if it could make sense to add that analyzer/connector to other freely available playbooks.
    • I have provided the resulting raw JSON of a finished analysis and a screenshot of the results.
    • If the plugin interacts with an external service, I have created an attribute called precisely url that contains this information. This is required for Health Checks.
    • If the plugin requires mocked testing, _monkeypatch() was used in its class to apply the necessary decorators.
    • I have added that raw JSON sample to the MockUpResponse of the _monkeypatch() method. This serves us to provide a valid sample for testing.
  • If external libraries/packages with restrictive licenses were used, they were added in the Legal Notice section.
  • Linters (Black, Flake, Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved (see tests folder). All the tests (new and old ones) gave 0 errors.
  • If changes were made to an existing model/serializer/view, the docs were updated and regenerated (check CONTRIBUTE.md).
  • If the GUI has been modified:
    • I have a provided a screenshot of the result in the PR.
    • I have created new frontend tests for the new component or updated existing ones.
  • After you had submitted the PR, if DeepSource, Django Doctors or other third-party linters have triggered any alerts during the CI checks, I have solved those alerts.

Important Rules

  • If you miss to compile the Checklist properly, your PR won't be reviewed by the maintainers.
  • Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review. After being reviewed and received a "change request", you should explicitly ask for a review again once you have made the requested changes.

PR Type

configuration changes


Description

  • Removed the version specification from the compose-tests.yml file in the cyberchef integration, simplifying the Docker Compose configuration.

Changes walkthrough 📝

Relevant files
Configuration changes
compose-tests.yml
Remove version specification from Docker Compose file       

integrations/cyberchef/compose-tests.yml

  • Removed the version specification from the Docker Compose file.
+0/-2     

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

Signed-off-by: NxPKG <iconmamundentist@gmail.com>
Copy link

sourcery-ai bot commented Nov 29, 2024

Reviewer's Guide by Sourcery

This PR makes a minor modification to the Docker Compose configuration file for CyberChef integration tests by removing the version specification.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Removed Docker Compose version specification
  • Removed 'version: 3.8' declaration from the compose file
  • Removed extra blank line after version declaration
integrations/cyberchef/compose-tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

coderabbitai bot commented Nov 29, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Docker Compose Version
Removing the version specification from docker-compose file may cause compatibility issues with different Docker Compose versions. Consider keeping version specification for better compatibility control.

Copy link

deepsource-io bot commented Nov 29, 2024

Here's the code health analysis summary for commits e28c23c..2bd7d93. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Docker LogoDocker✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Score
General
Maintain version specification in Docker Compose files to ensure consistent behavior across different environments

Re-add the Docker Compose version specification to ensure compatibility with
different Docker Compose versions and prevent potential deployment issues.

integrations/cyberchef/compose-tests.yml [1-4]

+version: '3.8'
+
 services:
   cyberchef-server:
     build:
       context: ../integrations/cyberchef
  • Apply this suggestion
Suggestion importance[1-10]: 8

Why: Removing the version specification could lead to compatibility issues across different Docker Compose versions and environments. The suggestion correctly identifies the need to maintain explicit versioning for better reliability and consistency.

8

💡 Need additional feedback ? start a PR chat

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @NxPKG - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please restore the Docker Compose version specification. Removing it could lead to inconsistent behavior across different environments. If there's a specific reason for removing it, please explain in the PR description.
  • The PR description template is not filled out. Please provide a summary of the changes and select the appropriate type of change (bug fix, new feature, or breaking change).
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Signed-off-by: NxPKG <iconmamundentist@gmail.com>
Signed-off-by: NxPKG <iconmamundentist@gmail.com>
Signed-off-by: NxPKG <iconmamundentist@gmail.com>
Signed-off-by: NxPKG <iconmamundentist@gmail.com>
Signed-off-by: NxPKG <iconmamundentist@gmail.com>
Signed-off-by: NxPKG <iconmamundentist@gmail.com>
Signed-off-by: NxPKG <iconmamundentist@gmail.com>
Signed-off-by: NxPKG <iconmamundentist@gmail.com>
@NxPKG NxPKG merged commit 90eee48 into develop Nov 29, 2024
8 checks passed
NxPKG added a commit that referenced this pull request Feb 6, 2025
* not-ready for CI/CD

* fix: ci

* fix: funding

* Update README.md

Signed-off-by: NxPKG <iconmamundentist@gmail.com>

* Update TLPSelectInput.jsx

Signed-off-by: NxPKG <iconmamundentist@gmail.com>

* Update notifications.jsx

Signed-off-by: NxPKG <iconmamundentist@gmail.com>

* Update TokenPage.jsx

Signed-off-by: NxPKG <iconmamundentist@gmail.com>

* Update GuideWrapper.jsx

Signed-off-by: NxPKG <iconmamundentist@gmail.com>

* Update TokenAccess.jsx

Signed-off-by: NxPKG <iconmamundentist@gmail.com>

* Create test_nvd_cve.py

Signed-off-by: NxPKG <iconmamundentist@gmail.com>

* Create __init__.py

Signed-off-by: NxPKG <iconmamundentist@gmail.com>

* Create 0130_analyzer_config_nvd_cve.py

Signed-off-by: NxPKG <iconmamundentist@gmail.com>

* Create nvd_cve.py

Signed-off-by: NxPKG <iconmamundentist@gmail.com>

* Update project-requirements.txt

Signed-off-by: NxPKG <iconmamundentist@gmail.com>

* Update project-requirements.txt

Signed-off-by: NxPKG <iconmamundentist@gmail.com>

* update

* update

* Fix retry (#181)

Signed-off-by: NxPKG <iconmamundentist@gmail.com>

* Update RecentScans.jsx (#182)

Signed-off-by: NxPKG <iconmamundentist@gmail.com>

* Update compose-tests.yml (#183)

* Update compose-tests.yml

Signed-off-by: NxPKG <iconmamundentist@gmail.com>

* Update compose.yml

Signed-off-by: NxPKG <iconmamundentist@gmail.com>

* Update compose-tests.yml

Signed-off-by: NxPKG <iconmamundentist@gmail.com>

* Update compose.yml

Signed-off-by: NxPKG <iconmamundentist@gmail.com>

* Update compose-tests.yml

Signed-off-by: NxPKG <iconmamundentist@gmail.com>

* Update compose.yml

Signed-off-by: NxPKG <iconmamundentist@gmail.com>

* Update compose.yml

Signed-off-by: NxPKG <iconmamundentist@gmail.com>

* Update compose-tests.yml

Signed-off-by: NxPKG <iconmamundentist@gmail.com>

* Update compose.yml

Signed-off-by: NxPKG <iconmamundentist@gmail.com>

---------

Signed-off-by: NxPKG <iconmamundentist@gmail.com>

* fixed dashboard backend unittest

* black format

* fix isort

* prettier:write fix

* Update test_auth.py

Signed-off-by: gitworkflows <118260833+gitworkflows@users.noreply.github.com>

* Update project-requirements.txt

Signed-off-by: gitworkflows <118260833+gitworkflows@users.noreply.github.com>

* Update serializers.py (#206)

* Update serializers.py

Signed-off-by: gitworkflows <118260833+gitworkflows@users.noreply.github.com>

* Update urls.py

Signed-off-by: gitworkflows <118260833+gitworkflows@users.noreply.github.com>

* Update views.py

Signed-off-by: gitworkflows <118260833+gitworkflows@users.noreply.github.com>

* Update urls.py

Signed-off-by: gitworkflows <118260833+gitworkflows@users.noreply.github.com>

* Update views.py

Signed-off-by: gitworkflows <118260833+gitworkflows@users.noreply.github.com>

* Update urls.py

Signed-off-by: gitworkflows <118260833+gitworkflows@users.noreply.github.com>

* Update views.py

Signed-off-by: gitworkflows <118260833+gitworkflows@users.noreply.github.com>

* Update serializers.py

Signed-off-by: gitworkflows <118260833+gitworkflows@users.noreply.github.com>

* Update urls.py

Signed-off-by: gitworkflows <118260833+gitworkflows@users.noreply.github.com>

* Update views.py

Signed-off-by: gitworkflows <118260833+gitworkflows@users.noreply.github.com>

* Refactor Plugin Config

* Refactor Plugin Config

---------

Signed-off-by: gitworkflows <118260833+gitworkflows@users.noreply.github.com>

* Update package.json

Signed-off-by: gitworkflows <118260833+gitworkflows@users.noreply.github.com>

* Update package-lock.json

Signed-off-by: gitworkflows <118260833+gitworkflows@users.noreply.github.com>

* Bump eslint-plugin-react from 7.37.1 to 7.37.3 in /frontend (#201)

Bumps [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react) from 7.37.1 to 7.37.3.
- [Release notes](https://github.com/jsx-eslint/eslint-plugin-react/releases)
- [Changelog](https://github.com/jsx-eslint/eslint-plugin-react/blob/v7.37.3/CHANGELOG.md)
- [Commits](jsx-eslint/eslint-plugin-react@v7.37.1...v7.37.3)

---
updated-dependencies:
- dependency-name: eslint-plugin-react
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Frontend - Search page (elastic gui) (#209)

* Frontend - Search page (elastic gui)

* Frontend - Search page (elastic gui)

* Frontend - Search page (elastic gui)

* Update AppHeader.jsx

Signed-off-by: NxPKG <iconmamundentist@gmail.com>

* Update test_views.py

Signed-off-by: NxPKG <iconmamundentist@gmail.com>

---------

Signed-off-by: NxPKG <iconmamundentist@gmail.com>

* Bump github/codeql-action from 2.22.11 to 3.28.8 (#224)

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.11 to 3.28.8.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Commits](github/codeql-action@v2.22.11...v3.28.8)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* update

* update

* update

* update

* update

---------

Signed-off-by: NxPKG <iconmamundentist@gmail.com>
Signed-off-by: gitworkflows <118260833+gitworkflows@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: NxPKG <iconmamundentist@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: KhulnaSoft bot <technosulaiman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant