-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: action image-release #5
Conversation
Signed-off-by: gitworkflows <118260833+gitworkflows@users.noreply.github.com>
Reviewer's Guide by SourceryThis pull request modifies the image release workflow to use GitHub Container Registry (ghcr.io) instead of Quay.io for storing Docker images. It updates the authentication process and image tagging to reflect this change. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @gitworkflows - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider updating the PR description to explain the motivation behind switching from Quay.io to GitHub Container Registry. This context would be helpful for reviewers and future contributors.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
User description
Notes for Reviewers
This PR fixes #
Signed commits
PR Type
enhancement, configuration changes
Description
ghcr.io
) instead ofquay.io
.Changes walkthrough 📝
image-release.yaml
Update Docker image release workflow to use GitHub Container Registry
.github/workflows/image-release.yaml
quay.io
toghcr.io
.ghcr.io
.Summary by Sourcery
CI: