Skip to content

Commit

Permalink
feat(kiali-server): add custom nodeport for service (#248)
Browse files Browse the repository at this point in the history
* feat(kiali-server): add custom nodeport for service

* fix: service type node-port capital "N"

* Apply suggestions from code review

Co-authored-by: John Mazzitelli <mazz@redhat.com>

* Update kiali-server/templates/service.yaml

Co-authored-by: John Mazzitelli <mazz@redhat.com>

* Update kiali-server/values.yaml

Co-authored-by: John Mazzitelli <mazz@redhat.com>

* Update kiali-server/values.yaml

Co-authored-by: John Mazzitelli <mazz@redhat.com>

* Update kiali-server/values.yaml

Co-authored-by: John Mazzitelli <mazz@redhat.com>

* Update kiali-server/templates/service.yaml

Co-authored-by: John Mazzitelli <mazz@redhat.com>

* add node_port field to values

---------

Co-authored-by: Yunus Emre Berber <emre.berber@trendyol.com>
Co-authored-by: John Mazzitelli <mazz@redhat.com>
  • Loading branch information
3 people authored Feb 19, 2024
1 parent 02c3ab3 commit 9646112
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions kiali-server/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ spec:
{{- end }}
protocol: TCP
port: {{ .Values.server.port }}
{{- if and (not (empty .Values.server.node_port)) (eq .Values.deployment.service_type "NodePort") }}
nodePort: {{ .Values.server.node_port }}
{{- end }}
{{- if .Values.server.observability.metrics.enabled }}
- name: http-metrics
appProtocol: http
Expand Down
1 change: 1 addition & 0 deletions kiali-server/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ login_token:

server:
port: 20001
#node_port:
observability:
metrics:
enabled: true
Expand Down

0 comments on commit 9646112

Please sign in to comment.