have the release workflow run the smoketest. #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with a loud warning and indicate it should not be merged. Otherwise, create the PR as it normally does. fixes kiali/kiali#6704
|
this should work now |
|
I did two tests .. 1. smoke test fails and 2. smoke test succeeded. It behaves as expected both times. This is ready for merge. |
|
This is what the resulting PR will look like if the smoke test fails: |
Matiasmct
pushed a commit
to giffgaff/kiali-charts-backup
that referenced
this pull request
Nov 29, 2023
kiali#232) with a loud warning and indicate it should not be merged. Otherwise, create the PR as it normally does. fixes kiali/kiali#6704
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it fails, title the PR with a loud warning and indicate it should not be merged. Otherwise, create the PR as it normally does.
fixes kiali/kiali#6704