Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top level clustering field #242

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Conversation

nrfox
Copy link
Contributor

@nrfox nrfox commented Jan 11, 2024

Adds a top level clustering field to the kiali spec.

Relates to kiali/kiali#6243

@nrfox nrfox marked this pull request as ready for review January 11, 2024 19:25
@nrfox nrfox requested a review from jmazzitelli January 11, 2024 19:26
Copy link
Contributor

@jmazzitelli jmazzitelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to do 2 things:

  1. You should remove the deprecated feature flags from values.yaml.

  2. Then you need to change the templates to use these new settings:

So you will want to change this stuff:

You can see all these places that use the feature flags via:

$ grep -R "kiali_feature_flags.clustering" *
templates/_helpers.tpl:{{- if .Values.kiali_feature_flags.clustering.autodetect_secrets.enabled }}
templates/_helpers.tpl:  {{- $secretLabelToLookFor := (regexSplit "=" .Values.kiali_feature_flags.clustering.autodetect_secrets.label 2) }}
templates/deployment.yaml:        {{- range .Values.kiali_feature_flags.clustering.clusters }}
templates/deployment.yaml:      {{- range .Values.kiali_feature_flags.clustering.clusters }}

This is the server helm chart (provided for convienence) so we are less strict about backwards compatibility. We will, however, make a note of this in the release notes so people are aware of this change. cc @jshaughn (he produces the release notes).

@nrfox nrfox merged commit 47c2b08 into kiali:master Jan 12, 2024
1 check passed
@nrfox nrfox deleted the add-clustering-field branch January 12, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants