Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kiali-server): add custom nodeport for service #248

Merged
merged 9 commits into from
Feb 19, 2024
Merged

feat(kiali-server): add custom nodeport for service #248

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
97b2e4d
feat(kiali-server): add custom nodeport for service
Feb 14, 2024
cfe087d
fix: service type node-port capital "N"
emreberber Feb 14, 2024
783e64c
Apply suggestions from code review
emreberber Feb 16, 2024
9d471fe
Update kiali-server/templates/service.yaml
emreberber Feb 16, 2024
e5ea44b
Update kiali-server/values.yaml
emreberber Feb 16, 2024
09ee797
Update kiali-server/values.yaml
emreberber Feb 16, 2024
2cbfc52
Update kiali-server/values.yaml
emreberber Feb 19, 2024
038a8e4
Update kiali-server/templates/service.yaml
emreberber Feb 19, 2024
e3af335
add node_port field to values
emreberber Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions kiali-server/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,17 @@ spec:
{{- end }}
protocol: TCP
port: {{ .Values.server.port }}
{{- if eq .Values.deployment.service_type "NodePort" }}
emreberber marked this conversation as resolved.
Show resolved Hide resolved
nodePort: {{ .Values.server.nodePort }}
emreberber marked this conversation as resolved.
Show resolved Hide resolved
{{- end }}
{{- if .Values.server.observability.metrics.enabled }}
- name: http-metrics
appProtocol: http
protocol: TCP
port: {{ .Values.server.observability.metrics.port }}
{{- if eq .Values.deployment.service_type "NodePort" }}
nodePort: {{ .Values.server.observability.metrics.nodePort }}
{{- end }}
emreberber marked this conversation as resolved.
Show resolved Hide resolved
{{- end }}
selector:
{{- include "kiali-server.selectorLabels" . | nindent 4 }}
Expand Down
2 changes: 2 additions & 0 deletions kiali-server/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,10 @@ login_token:

server:
port: 20001
nodePort: 32475
emreberber marked this conversation as resolved.
Show resolved Hide resolved
observability:
metrics:
enabled: true
port: 9090
nodePort: 32476
emreberber marked this conversation as resolved.
Show resolved Hide resolved
web_root: ""