Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove verbose_mode that has been deprecated #251

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

jmazzitelli
Copy link
Contributor

It has been deprecated/superceded since v1.26 (4 years ago)

part of: kiali/kiali#7208

It has been deprecated/superceded since v1.26 (4 years ago)

part of: kiali/kiali#7208
@jmazzitelli
Copy link
Contributor Author

how to test:

  1. make build-helm-charts
  2. helm template kiali kiali-server --show-only templates/deployment.yaml --set deployment.logger.log_level=error

Look at the output - find the LOG_LEVEL env var definition, it should say "error". This means everything worked, and nothing broke with the removal of the verbose_mode support.

        - name: LOG_LEVEL
          value: "error"

@jmazzitelli jmazzitelli merged commit 0574de3 into kiali:master Mar 21, 2024
1 check passed
@jmazzitelli jmazzitelli deleted the 7208-doom-verbose-mode branch March 21, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires operator PR Requires changes to the operator
Projects
Development

Successfully merging this pull request may close these issues.

2 participants