Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kiali-operator] Add podSecurityContext for deployment #270

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brainstorm82
Copy link

Added podSecurityContext for kiali operator deployment

Verified

This commit was signed with the committer’s verified signature.
brainstorm82 Andreas Seelinger
Signed-off-by: Andreas Seelinger <Andreas.Seelinger@accenture.com>
Copy link
Contributor

@jmazzitelli jmazzitelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When asking for enhancements to Kiali, please follow the community contribution process as defined here:

https://github.com/kiali/kiali/blob/master/CONTRIBUTING.md#making-a-change

Note: there is already a security context you can set on the container which contain some default constraints when not set. As per the contribution doc, please create an issue with a description of the request, your use-case, and why the current feature set doesn't support it.

@aravol
Copy link

aravol commented Dec 5, 2024

Noting that this is causing problems in our deployment, since defaults occaisionally set securityContext: [] which prevents Kiali from accessing logs

@brainstorm82
Copy link
Author

Can you provide more information on your configuration. So the change would need to not create securtiyContext at all if not set. Since no securityContext is not the same as securityContext: {}

@jmazzitelli
Copy link
Contributor

jmazzitelli commented Dec 5, 2024

Can someone create a github issue on this so we can discuss there? This may affect more than just the op helm chart. See my previous comment on this. These are the types of conversations we should have in the issue and then we can submit PRs once we determine what needs to get done.

@jshaughn
Copy link

Issue created: kiali/kiali#7987

@jmazzitelli
Copy link
Contributor

Issue created: kiali/kiali#7987

DOH! I JUST created one myself!

kiali/kiali#7988

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants