Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of: kiali/kiali#7559
To test this:
/tmp/values.yaml
) - note that HPA is defined and an abnormally large value fordeployment.replicas
is set - you will notice that large replicas value won't appear in the generated yaml:make build-helm-charts
spec.replicas
in the generated Deployment (notice the large value for replicas does not appear in the output):spec.replicas
still takes effect if HPA is not defined (HPA is not defined by default, so just set the replicas on the command line, no need for a values file specified on the command line for this test, and only dump the deployment template since there is no HPA template for this test):