Skip to content

Commit

Permalink
Fix upgrade with no label_selector_include (#6778) (#703)
Browse files Browse the repository at this point in the history
When `label_selector_include` is not set in Kiali CR, upgrade
still tries to patch some namespaces as variable used to retrieve it has
empty string as value.
Make sure it's not the case anymore.

Signed-off-by: Sylvain Desbureaux <sylvain.desbureaux@orange.com>
  • Loading branch information
sylvainOL authored Oct 26, 2023
1 parent 4b4e941 commit b732a25
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions roles/default/kiali-deploy/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -788,6 +788,7 @@
- current_cluster_wide_access is defined
- current_cluster_wide_access|bool == False
- current_label_selector_include is defined
- current_label_selector_include != ""
- kiali_vars.api.namespaces.label_selector_include is defined
- current_label_selector_include != kiali_vars.api.namespaces.label_selector_include

Expand Down Expand Up @@ -884,6 +885,7 @@
when:
- no_longer_accessible_namespaces is defined
- current_label_selector_include is defined
- current_label_selector_include != ""

- name: Create additional Kiali label on all accessible namespaces
vars:
Expand Down

0 comments on commit b732a25

Please sign in to comment.