Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create provider field in the tracing config #679

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Create provider field in the tracing config #679

merged 2 commits into from
Sep 26, 2023

Conversation

josunect
Copy link
Contributor

Ref. kiali/kiali#6518

Example:

  tracing:
    enabled: true
    provider: "tempo"
    in_cluster_url: http://localhost:16685
    url: http://localhost:16686

@josunect josunect added the enhancement New feature or request label Aug 30, 2023
@josunect josunect self-assigned this Aug 30, 2023
jmazzitelli
jmazzitelli approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@jmazzitelli jmazzitelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is still in draft mode, but I approve it nonetheless :)

@josunect josunect marked this pull request as ready for review September 4, 2023 08:19
@josunect josunect merged commit a204a5e into kiali:master Sep 26, 2023
@josunect josunect deleted the issue5849 branch September 26, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmazzitelli jmazzitelli jmazzitelli approved these changes

Assignees

@josunect josunect

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josunect @jmazzitelli